Bug 37063

Summary: Tighten SheriffBot's flaky test detector
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 36911    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-04-03 14:01:40 PDT
Tighten SheriffBot's flaky test detector
Attachments
Patch (12.51 KB, patch)
2010-04-03 14:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.61 KB, patch)
2010-04-05 00:24 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-03 14:08:20 PDT
Created attachment 52500 [details] Patch
Adam Barth
Comment 2 2010-04-04 09:56:07 PDT
Need to add "Tests that caused the DumpRenderTree tool to crash:" as a results key.
Eric Seidel (no email)
Comment 3 2010-04-04 23:27:30 PDT
This patch really wants bug 36911 to be landed first. :)
Adam Barth
Comment 4 2010-04-05 00:24:02 PDT
Created attachment 52518 [details] Patch
Adam Barth
Comment 5 2010-04-05 00:25:00 PDT
Committed r57065: <http://trac.webkit.org/changeset/57065>
Adam Barth
Comment 6 2010-04-05 00:25:58 PDT
Sorry for landing this change unreviewed. I pulled over the relevant code from Bug 36911. I'm leaving this bug open so Eric can give me an after-the-fact review when he wakes up.
Eric Seidel (no email)
Comment 7 2010-04-05 14:00:52 PDT
Comment on attachment 52518 [details] Patch This really wanted bug 36911, since this is basicaly a re-write of that logic. :( test_no_results is wrong. Otherwise looks OK.
Daniel Bates
Comment 8 2010-05-17 00:56:29 PDT
What is the status with this bug? Can we close it?
Note You need to log in before you can comment on or make changes to this bug.