Bug 36910

Summary: 3 test failures on Snow Leopard bot from 33416
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric, fishd, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch none

Kenneth Russell
Reported 2010-03-31 17:44:54 PDT
Per comment 40 on bug 33416, there are three WebGL test failures on the Snow Leopard bot introduced by this patch because the EXT_packed_depth_stencil extension is unsupported. The tests are incorrect; according to the WebGL spec, it is legal for an implementation to not be able to honor the request for a stencil buffer.
Attachments
patch (9.14 KB, patch)
2010-03-31 18:30 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-03-31 18:30:22 PDT
Created attachment 52231 [details] patch
Eric Seidel (no email)
Comment 2 2010-03-31 18:34:30 PDT
Comment on attachment 52231 [details] patch Someone who actually knows WebGL should do a review here. Or a non-reviewer who knows WebGL could explain why this is right and then I'm happy to r+. :)
Kenneth Russell
Comment 3 2010-03-31 18:47:08 PDT
Comment on attachment 52231 [details] patch The patch looks good to me. Based on this behavior I think we might want to reconsider some of the rules in the WebGL spec, but this is beyond the scope of this fix.
Eric Seidel (no email)
Comment 4 2010-03-31 18:56:47 PDT
Comment on attachment 52231 [details] patch Seems reasonable. Thank you for the quick fix.
WebKit Commit Bot
Comment 5 2010-03-31 19:09:06 PDT
Comment on attachment 52231 [details] patch Clearing flags on attachment: 52231 Committed r56886: <http://trac.webkit.org/changeset/56886>
WebKit Commit Bot
Comment 6 2010-03-31 19:09:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.