Bug 36538

Summary: [Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: WebKit QtAssignee: Diego Gonzalez <diegohcg>
Status: CLOSED FIXED    
Severity: Normal CC: benjamin, commit-queue, diegohcg, hausmann, jturcotte, kenneth, laszlo.gombos, tonikitoo, vestbo
Priority: P1 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Proposed patch
none
Changed to use QT_WEBKIT_VERSION
none
Using QTWEBKIT none

Simon Hausmann
Reported 2010-03-24 09:43:32 PDT
We need a #define in qtwebkitglobal.h that contains the version of QtWebKit, so that application developers can detect it.
Attachments
Proposed patch (1.71 KB, patch)
2010-03-29 13:14 PDT, Diego Gonzalez 		no flags
DetailsFormatted DiffDiff
Changed to use QT_WEBKIT_VERSION (1.74 KB, patch)
2010-04-01 13:56 PDT, Diego Gonzalez 		no flags
DetailsFormatted DiffDiff
Using QTWEBKIT (1.73 KB, patch)
2010-04-06 07:01 PDT, Diego Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2010-03-24 12:21:01 PDT
We might need to change our User Agent as well as it currently shows the Qt version. I do not know if this still makes sense.
Diego Gonzalez
Comment 2 2010-03-29 13:14:40 PDT
Created attachment 51957 [details] Proposed patch Is something like this patch the required?
Simon Hausmann
Comment 3 2010-03-30 08:16:01 PDT
Comment on attachment 51957 [details] Proposed patch Thanks Diego!!
Simon Hausmann
Comment 4 2010-03-30 08:17:14 PDT
Jocelyn, Tor Arne: Would be great if you could double check this trivial patch. Thanks :) I recall discussing the name/location of this macro, but it doesn't hurt to double check.
Jocelyn Turcotte
Comment 5 2010-03-30 11:19:37 PDT
(In reply to comment #4) > Jocelyn, Tor Arne: Would be great if you could double check this trivial patch. > Thanks :) > > I recall discussing the name/location of this macro, but it doesn't hurt to > double check. I remember having a concern about the ambiguity of QtWebKit's version vs. WebKit's version. The function to get the WebKit's version is called qWebKitVersion(). I would prefer these macros to be called QTWEBKIT_VERSION, QT_WEBKIT_VERSION, QQTWEBKIT_VERSION or QWEBKIT_QTWEBKIT_VERSION instead of QWEBKIT_VERSION.
Diego Gonzalez
Comment 6 2010-03-30 17:07:50 PDT
> I would prefer these macros to be called QTWEBKIT_VERSION, QT_WEBKIT_VERSION, > QQTWEBKIT_VERSION or QWEBKIT_QTWEBKIT_VERSION instead of QWEBKIT_VERSION. So, in this case I vote for QT_WEBKIT_VERSION. What do you thing guys?
Diego Gonzalez
Comment 7 2010-04-01 13:56:22 PDT
Created attachment 52331 [details] Changed to use QT_WEBKIT_VERSION using QT_WEBKIT_VERSION
Eric Seidel (no email)
Comment 8 2010-04-01 15:57:32 PDT
Comment on attachment 51957 [details] Proposed patch Looks like there was a new version of this patch posted. Obsoleting this one.
Diego Gonzalez
Comment 9 2010-04-06 07:01:09 PDT
Created attachment 52632 [details] Using QTWEBKIT
WebKit Commit Bot
Comment 10 2010-04-06 10:29:45 PDT
Comment on attachment 52632 [details] Using QTWEBKIT Clearing flags on attachment: 52632 Committed r57155: <http://trac.webkit.org/changeset/57155>
WebKit Commit Bot
Comment 11 2010-04-06 10:29:52 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 12 2010-04-07 00:30:31 PDT
Revision r57155 cherry-picked into qtwebkit-2.0 with commit ce3cdb4157cea4f4d80e6498307ea65de2c36b93
Note You need to log in before you can comment on or make changes to this bug.