Bug 34031

Summary: check-webkit-style: Remove the filename parameter from the style error handler functions
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Chris Jerdonek
Reported 2010-01-22 19:08:16 PST
The filename parameter is unnecessary since it is the same for all errors processed within a file. This refactoring will simplify the code a bit.
Attachments
Proposed patch (52.88 KB, patch)
2010-01-22 19:46 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-01-22 19:46:46 PST
Created attachment 47262 [details] Proposed patch
Chris Jerdonek
Comment 2 2010-01-22 19:51:14 PST
(In reply to comment #1) > Created an attachment (id=47262) [details] > Proposed patch Just saw the size of this patch (53K). FYI, I'd estimate that 85% of the size of this patch or so results from this simple search and replace: "error(filename, " -> "error(".
Shinichiro Hamaji
Comment 3 2010-01-25 20:56:56 PST
Comment on attachment 47262 [details] Proposed patch Sorry for the latency. I was a bit sick and busy these days.
Chris Jerdonek
Comment 4 2010-01-25 21:02:07 PST
(In reply to comment #3) > (From update of attachment 47262 [details]) > Sorry for the latency. I was a bit sick and busy these days. Thanks. Hope you're feeling better...
Chris Jerdonek
Comment 5 2010-01-25 23:37:49 PST
Comment on attachment 47262 [details] Proposed patch Clearing flags on attachment: 47262 Committed r53841: <http://trac.webkit.org/changeset/53841>
Chris Jerdonek
Comment 6 2010-01-25 23:37:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.