Bug 33834

Summary: [Qt] REGRESSION (r53450): 3 tests fail on Qt bot
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kent.hansen, laszlo.gombos, mitz, ossy, sam
Priority: P2 Keywords: Qt, QtTriaged, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 36954    
Bug Blocks: 79666    
Attachments:
Description Flags
make buildbot happy none

Csaba Osztrogonác
Reported 2010-01-19 00:59:46 PST
Unfortunately I can't find the original bug for r49567, so I filed a new one. r49567 reverted by r53450. This revert cause 3 tests fail on Qt bot: css1/box_properties/acid_test.html - wasn't modified by r53450 css1/font_properties/font.html fast/forms/textarea-scrollbar-height.html - wasn't modified by r53450 detailed results: http://build.webkit.org/results/Qt%20Linux%20Release/r53460%20%286164%29/results.html
Attachments
make buildbot happy (6.48 KB, patch)
2010-01-19 02:41 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-01-19 02:13:51 PST
1.) css1/box_properties/acid_test.html fail caused by: form p { line-height: 1.9; } 2.) css1/font_properties/font.html needs to be updated 3.) fast/forms/textarea-scrollbar-height.html fail caused by: {font:13px/1.22 arial;}
Csaba Osztrogonác
Comment 2 2010-01-19 02:15:59 PST
original commit link: http://trac.webkit.org/changeset/49567 revert commit link: http://trac.webkit.org/changeset/53450
Csaba Osztrogonác
Comment 3 2010-01-19 02:41:47 PST
Created attachment 46899 [details] make buildbot happy I suggest we should update css1/font_properties/font.html and skip the others.
Csaba Osztrogonác
Comment 4 2010-01-19 03:05:10 PST
Comment on attachment 46899 [details] make buildbot happy landed in http://trac.webkit.org/changeset/53463
Kent Hansen
Comment 5 2010-03-12 07:39:39 PST
Can this be closed now(In reply to comment #4) > (From update of attachment 46899 [details]) > landed in http://trac.webkit.org/changeset/53463 Can this bug be closed now, or do you intend to unskip the two tests? In any case, it might make sense to create spin-offs for those two (and add relevant dependencies) if it's not just a matter of updating the tests.
Csaba Osztrogonác
Comment 6 2010-03-12 07:58:38 PST
css1/box_properties/acid_test.html now passes, unskipped by http://trac.webkit.org/changeset/55902 fast/forms/textarea-scrollbar-height.html still fails, so we shouldn't close this bug. I think it is needless to file a new bug and dependency for only one test.
Kent Hansen
Comment 7 2010-03-12 08:01:27 PST
(In reply to comment #6) > css1/box_properties/acid_test.html now passes, unskipped by > http://trac.webkit.org/changeset/55902 > > fast/forms/textarea-scrollbar-height.html still fails, so we shouldn't close > this bug. I think it is needless to file a new bug and dependency for only one > test. Cool, as long as it's just a matter of updating the test then that sounds fine.
Csaba Osztrogonác
Comment 8 2010-04-01 05:19:56 PDT
(In reply to comment #7) > Cool, as long as it's just a matter of updating the test then that sounds fine. Unfortunately css1/box_properties/acid_test.html fails on 32 bit linux in release mode , but passes in debug mode and passes on 64 bit in release/debug mode. It is skipped again until fix: http://trac.webkit.org/changeset/55907 see the new bug: https://bugs.webkit.org/show_bug.cgi?id=36954
Note You need to log in before you can comment on or make changes to this bug.