Bug 33433

e3.setAttribute("onload", "if (window.layoutTestController) setTimeout('layoutTestController.notifyDone()', 100)"); I suspect this test is timing dependent and just flakey in general.

Just filed on the Gtk bot too: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r53205%20(2366)/svg/dom/SVGScriptElement/script-set-href-diffs.txt

*** Bug 31107 has been marked as a duplicate of this bug. ***

Chromium's tracking tools have occasionally seen this fail as well: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=svg%2Fdom%2FSVGScriptElement%2Fscript-set-href.svg&showExpectations=true&showLargeExpectations=true

Created attachment 46514 [details] Patch

Comment on attachment 46514 [details] Patch Rejecting patch 46514 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11920 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 9735 tests run. 204.73s total testing time 9734 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/184832

Passed for me locally, so I must have done something wrong. Investigating.

Looking at the results off the (16 core) bot, looks like my fears came true: /tmp/layout-test-results/svg/dom/SVGScriptElement/script-set-href-actual.txt - Self-closing <script> tag: PASS + Self-closing <script> tag: FAIL - Set before insertion: PASS + Set before insertion: FAIL - Set after insertion: PASS + Set after insertion: FAIL Looks like the earlier tests hadn't completed by the time the later ones did. The best way to fix this would be to sign up for the onload events of all of the script tags and only end the test once all of them have fired.

I am not actively working on this bug.

Failed again for the commit-queue just now. Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12524 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 10243 tests run. 246.58s total testing time

Failed again on the Leopard Debug bot: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r56594%20(11967)/svg/dom/SVGScriptElement/script-set-href-diffs.txt I've seen it fail for the commit-queue locally as well.

Another leopard failure: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r56631%20(12178)/svg/dom/SVGScriptElement/script-set-href-diffs.txt

Changed component to SVG, so it shows up in my all-svg-bugs search.

*** Bug 56790 has been marked as a duplicate of this bug. ***

*** Bug 37560 has been marked as a duplicate of this bug. ***

*** Bug 60118 has been marked as a duplicate of this bug. ***

I suspect this patch could be turned into a final fix with little effort, but I'm not actively working on this (just noticed when cleaning out some old git branches).

We still have [ Failure Pass ] expectation added in 2014 for Mac platforms: https://searchfox.org/wubkat/rev/b96b33ee6c4c6dde7bf51c3744d6ccbc19a517e8/LayoutTests/platform/mac/TestExpectations#477

Currenty the test is still marked in TestExpectations as svg/dom/SVGScriptElement/script-set-href.svg [ Failure Pass ]

<rdar://problem/173894313>

Test gardening pull request: https://github.com/WebKit/WebKit/pull/61863

Test gardening commit 310416@main (484ade9792e3): <https://commits.webkit.org/310416@main> Reviewed commits have been landed. Closing PR #61863 and removing active labels.