Bug 324703
| Summary: | [GTK][WPE] TestInputMethodContext cannot observe the cursor area, notification counts or the preedit caret offset | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pena <spena> |
| Component: | WebKitGTK | Assignee: | Simon Pena <spena> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=324967 | ||
Simon Pena
`Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestInputMethodContext.cpp` has a mock `WebKitInputMethodContext` that all the input method API tests use. It presents the following gaps:
1. The mock does not implement the `notify_cursor_area` virtual function, so tests can't check what
cursor area the input method is given, or whether it is given one at all.
2. The mock always reports the preedit caret at the end of the preedit. No test can exercise a
caret inside the preedit, which is where several code paths differ.
3. The mock does not count notifications. A test can check that a notification arrived with the
right values, but not that one failed to arrive. Missing notifications are a common failure
mode for input methods.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Pena
Pull request: https://github.com/WebKit/WebKit/pull/74494
EWS
Committed 322053@main (978866cd7f3e): <https://commits.webkit.org/322053@main>
Reviewed commits have been landed. Closing PR #74494 and removing active labels.