Bug 321823
| Summary: | [macOS Debug] imported/w3c/web-platform-tests/fullscreen/model/move-to-fullscreen-iframe.html is a flaky crashing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marta Darbinyan <darbinyan> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | fred.wang, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Marta Darbinyan
The following test is flaky crash on macOS Debug.
imported/w3c/web-platform-tests/fullscreen/model/move-to-fullscreen-iframe.html
/Volumes/Data/worker/macOS-Tahoe-Debug-Build-EWS/build/Source/WebKit/WebProcess/WebPage/WebPage.cpp(10656) : T WebKit::WebPage::contentsToRootView(WebCore::FrameIdentifier, T) [T = WebCore::FloatRect]
1 0x1201c64dc WebCore::FloatRect WebKit::WebPage::contentsToRootView<WebCore::FloatRect>(WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect)
2 0x1201c6348 WebKit::WebPage::contentsToRootViewRect(WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&)
3 0x11d931564 auto void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>, void (WebCore::FloatRect)>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>&&, WTF::CompletionHandler<void (WebCore::FloatRect)>&&)::'lambda'(auto&&...)::operator()<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>(auto&&...) const
4 0x11d931440 std::__1::__invoke_result_impl<void, auto...>::type std::__1::__invoke[abi:sqn210106]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>, void (WebCore::FloatRect)>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>&&, WTF::CompletionHandler<void (WebCore::FloatRect)>&&)::'lambda'(auto&&...), WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>(auto&&...)
5 0x11d93140c decltype(auto) std::__1::__apply_tuple_impl[abi:sqn210106]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>, void (WebCore::FloatRect)>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect, WTF::CompletionHandler<void (WebCore::FloatRect)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>&&, WTF::CompletionHandler<void (WebCore::FloatRect)>&&)::'lambda'(auto&&...), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>, WebCore::FloatRect>, 0ul, 1ul>(WebKit::WebPage&&, WebKit::WebPage&&, std::__1::__tuple_indices<0ul, 1ul>)
Test results:
https://ews-build.webkit.org/#/builders/161/builds/45809
Test history:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffullscreen%2Fmodel%2Fmove-to-fullscreen-iframe.html&style=debug
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/184962474>
EWS
Test gardening commit 319211@main (20eba49ee7a8): <https://commits.webkit.org/319211@main>
Reviewed commits have been landed. Closing PR #71677 and removing active labels.
Frédéric Wang Nélar
I'm not able to reproduce on macOS with Tools/Scripts/run-webkit-tests --debug --repeat 1000 imported/w3c/web-platform-tests/fullscreen/model/move-to-fullscreen-iframe.html
Checking the test history, no crashes have been reported for more than one month. Before that, it was happening relatively
Sep 5, Sep 4, Sep 3 (twice), Sep 1 (twice), Aug 25, Aug 24, Aug 22, Aug 21, Aug 20, Aug 17, Aug 15, Aug 12 (twice).
So I would say the issue is fixed and we can remove the CRASH label.
Frédéric Wang Nélar
Test gardening pull request: https://github.com/WebKit/WebKit/pull/76192
EWS
Test gardening commit 322985@main (e85fb5ac846b): <https://commits.webkit.org/322985@main>
Reviewed commits have been landed. Closing PR #76192 and removing active labels.