Bug 320438
| Summary: | monotilejigsaws.pages.dev: Missing items | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | New Bugs | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Other | ||
| Hardware: | iPhone / iPad | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=10409 https://bugs.webkit.org/show_bug.cgi?id=321865 https://github.com/web-platform-tests/wpt/pull/62048 |
||
Karl Dubost
URL: https://monotilejigsaws.pages.dev/%E2%99%AC/%F0%9F%8C%86.svgz
Browser / Version: Safari
Operating System: iOS
Tested Another Browser: Yes Safari
Problem type: Site is not usable
Description: Missing items
Steps to Reproduce:
1. With Safari on iOS
2. Go to https://monotilejigsaws.pages.dev/%E2%99%AC/%F0%9F%8C%86.svgz
3.
This is a regression in the latest version of Safari. In previous versions, and on all versions of other browser engines (gecko and blink) along with QuteBrowser 2.5.4-2ubuntu1 on Linux Mint (which uses a previous webkit version) the jigsaw puzzle pieces display correctly.
In the current release version of Safari all the movable pieces are either black and can't be moved or do not show up at all.
Additionally another puzzle at https://monotilejigsaws.pages.dev/Spectre_of_Canberra.svgz seems to alternate between having pieces showing up fine/being movable and having all pieces show up black.
Initially reported at https://github.com/webcompat/web-bugs/issues/229578
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
Console displays:
[Error] TypeError: undefined is not an object (evaluating 'this.rightContainer.element.style.removeProperty')
layout
width
_updateControlsSize
_updateControlsIfNeeded
MediaController
createControls
[Error] TypeError: undefined is not an object (evaluating 'this.rightContainer.element.style.removeProperty')
layout
(anonymous function)
forEach
performScheduledLayout
_layout
_frameDidFire
This fails in STP 247.
And this is failing in MiniBrowser Top of the tree.
Radar WebKit Bug Importer
<rdar://problem/183402463>
Ahmad Saleem
Console error is stemming from our own internal media player - macos-inline-media-controls.js
Karl Dubost
The console TypeError and the missing puzzle pieces are not the same bug.
The reporter's note that a second puzzle works is what separates them.
🌆.svgz Spectre_of_Canberra.svgz
<video controls> 1 0
console TypeError yes no
pieces painted no yes
Both are XML documents with the same broken document.createElement.
Only the one with <video controls> throws and the throw is not what hides the pieces.
Ahmad, yes and the initial report says it might be a regression.
I wonder if it could be https://commits.webkit.org/315718@main
But it's not the only issue. There might be two issues.
And I haven't yet figured out what was failing.
Ahmad Saleem
(In reply to Karl Dubost from comment #4)
> The console TypeError and the missing puzzle pieces are not the same bug.
> The reporter's note that a second puzzle works is what separates them.
>
> 🌆.svgz Spectre_of_Canberra.svgz
> <video controls> 1 0
> console TypeError yes no
> pieces painted no yes
>
> Both are XML documents with the same broken document.createElement.
> Only the one with <video controls> throws and the throw is not what hides
> the pieces.
>
> Ahmad, yes and the initial report says it might be a regression.
> I wonder if it could be https://commits.webkit.org/315718@main
> But it's not the only issue. There might be two issues.
>
> And I haven't yet figured out what was failing.
https://commits.webkit.org/315718@main <- Does not lead to anything here.
If you are referring to:
[Error] TypeError: undefined is not an object (evaluating 'this.rightContainer.element.style.removeProperty')
layout
width
_updateControlsSize
_updateControlsIfNeeded
MediaController
createControls
[Error] TypeError: undefined is not an object (evaluating 'this.rightContainer.element.style.removeProperty')
layout
(anonymous function)
forEach
performScheduledLayout
_layout
_frameDidFire
Then they fire because we are in <svg> namespace while our media-controls have hardcoded HTML case. It is also literal cause of flakiness in this WPT: https://bugs.webkit.org/show_bug.cgi?id=307412
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/71711
EWS
Committed 319264@main (68a544edb81f): <https://commits.webkit.org/319264@main>
Reviewed commits have been landed. Closing PR #71711 and removing active labels.
Ahmad Saleem
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/62048