Bug 30998

Summary: [Gtk] Implement AtkDocument's locale support
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 25531    
Attachments:
Description Flags
proposed fix none

Joanmarie Diggs
Reported 2009-11-01 13:42:59 PST
Created attachment 42281 [details] proposed fix +++ This bug was initially created as a clone of Bug #30964 +++ We need to implement the AtkDocument interface. http://library.gnome.org/devel/atk/unstable/AtkDocument.html
Attachments
proposed fix (2.03 KB, patch)
2009-11-01 13:42 PST, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-11-02 03:31:25 PST
Comment on attachment 42281 [details] proposed fix > static const gchar* webkit_accessible_document_get_locale(AtkDocument* document) > { > - // FIXME: This needs to be implemented. > - notImplemented(); > + > + // TODO: Should we fall back on lang xml:lang when the following comes up empty? > + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); > + if (!language.isEmpty()) > + return returnString(language); Should this return NULL if empty?
Joanmarie Diggs
Comment 2 2009-11-02 03:37:17 PST
(In reply to comment #1) > (From update of attachment 42281 [details]) > > static const gchar* webkit_accessible_document_get_locale(AtkDocument* document) > > { > > - // FIXME: This needs to be implemented. > > - notImplemented(); > > + > > + // TODO: Should we fall back on lang xml:lang when the following comes up empty? > > + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); > > + if (!language.isEmpty()) > > + return returnString(language); > > Should this return NULL if empty? I think so. Do you think otherwise? Or am I missing something? - // FIXME: This needs to be implemented. - notImplemented(); + + // TODO: Should we fall back on lang xml:lang when the following comes up empty? + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); + if (!language.isEmpty()) + return returnString(language); + return 0; ^^^^^^^^^
Jan Alonzo
Comment 3 2009-11-02 03:44:28 PST
Comment on attachment 42281 [details] proposed fix > return 0; Yup, I missed it. :) r=me.
WebKit Commit Bot
Comment 4 2009-11-02 09:35:42 PST
Comment on attachment 42281 [details] proposed fix Clearing flags on attachment: 42281 Committed r50412: <http://trac.webkit.org/changeset/50412>
WebKit Commit Bot
Comment 5 2009-11-02 09:35:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.