Bug 289204
Summary: | [ macOS ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close.html is a flaky failure. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Yasmin Karimi <y_karimi> |
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ntim, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Yasmin Karimi
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close.html
This test is a flaky failure on macOS.
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Finteractive-elements%2Fthe-dialog-element%2Ffocus-after-close.html
DIFF:
@@ -6,5 +6,5 @@
PASS Focus should be moved to the previously focused element even if it has moved to shadow DOM root in between show/close
PASS Focus should be moved to the body if the previously focused element is removed
PASS Focus should be moved to the shadow DOM host if the previouly focused element is a shadow DOM node
-PASS Focus should not scroll if the previously focused element is outside the viewport
+FAIL Focus should not scroll if the previously focused element is outside the viewport assert_true: expected true got false
DIFF URL:
https://build.webkit.org/results/Apple-Sequoia-Debug-AppleSilicon-WK1-Tests/291647@main%20(1391)/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-pretty-diff.html
REPRODUCIBILITY:
I was able to reproduce this failure on MacOS Sequoia 15.3.1 (24D70 / arm64) at ToT with the following command:
run-webkit-tests imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close.html --debug --iterations 500
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146338224>
EWS
Test gardening commit 291664@main (0219cf962a22): <https://commits.webkit.org/291664@main>
Reviewed commits have been landed. Closing PR #41958 and removing active labels.
Ryosuke Niwa
Fixing this test in the upstream: https://github.com/web-platform-tests/wpt/pull/51442
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/42705
EWS
Committed 292381@main (951344536cf4): <https://commits.webkit.org/292381@main>
Reviewed commits have been landed. Closing PR #42705 and removing active labels.
Ryosuke Niwa
*** Bug 238749 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
This test appears to be no longer flaky.
Ryosuke Niwa
Removed the flaky test expectation in https://commits.webkit.org/292500@main.