Bug 27510

Summary: [S60 QtWebKit] Don't put some intermediate generated files into the final mmp project file for linking.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: Other   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Point variable_out properties of effected custom compilers to empty, to avoid putting generated files into mmp project file.
none
update the patch discription to mention it is a workaround for qmake bug in Symbian port. hausmann: review+

Yongjun Zhang
Reported 2009-07-21 12:39:35 PDT
Some generated files (like CSSPropertyNames.cpp, ColorData.c, tokenizer.cpp) are to be included in WebCore source files. In S60 port, they are put into the final mmp project, perceived as normal source file. This breaks the build in S60 qtwebkit because some of them are not intended for building separately.
Attachments
Point variable_out properties of effected custom compilers to empty, to avoid putting generated files into mmp project file. (4.76 KB, patch)
2009-07-21 12:47 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
update the patch discription to mention it is a workaround for qmake bug in Symbian port. (4.73 KB, patch)
2009-07-23 13:16 PDT, Yongjun Zhang 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-07-21 12:47:10 PDT
Created attachment 33201 [details] Point variable_out properties of effected custom compilers to empty, to avoid putting generated files into mmp project file.
Yongjun Zhang
Comment 2 2009-07-23 13:16:51 PDT
Created attachment 33359 [details] update the patch discription to mention it is a workaround for qmake bug in Symbian port.
Simon Hausmann
Comment 3 2009-07-23 13:46:00 PDT
Comment on attachment 33359 [details] update the patch discription to mention it is a workaround for qmake bug in Symbian port. r=me
Simon Hausmann
Comment 4 2009-07-23 13:48:37 PDT
Landed in r46284
Note You need to log in before you can comment on or make changes to this bug.