Bug 26479

Summary: Share code between filterEffects
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jeffschiller
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389, 26480    
Attachments:
Description Flags
Share the code oliver: review+

Dirk Schulze
Reported 2009-06-17 07:15:49 PDT
We can share more code between the effects. The imageBuffer creation and drawRect calculation to Filtereffect.
Attachments
Share the code (5.88 KB, patch)
2009-06-17 07:18 PDT, Dirk Schulze 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2009-06-17 07:18:17 PDT
Created attachment 31412 [details] Share the code share the code
Dirk Schulze
Comment 2 2009-06-17 08:00:06 PDT
*** Bug 26478 has been marked as a duplicate of this bug. ***
Oliver Hunt
Comment 3 2009-06-18 01:11:14 PDT
Comment on attachment 31412 [details] Share the code I think it makes sense to hoist 78 GraphicsContext* filterContext = getEffectContext(); 79 if (!filterContext) 80 return; to above the creation of dstRect for clarity
Dirk Schulze
Comment 4 2009-06-18 13:01:23 PDT
landed in r44810.
Note You need to log in before you can comment on or make changes to this bug.