Bug 248714
| Summary: | Align Document::fullscreenEnabled and Document::webkitFullscreenEnabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | DOM | Assignee: | Frédéric Wang Nélar <fred.wang> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Tim Nguyen (:ntim)
The original implementation of the unprefixed API tried to make as little change as possible to the prefixed API.
The only difference between the two methods is the `isFullyActive()` check. Since we successfully unified that check for `Element::requestFullscreen` in https://commits.webkit.org/255551@main, we should also do it for `Document::fullscreenEnabled`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102937855>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/7117
Frédéric Wang Nélar
Pull request: https://github.com/WebKit/WebKit/pull/76479
EWS
Committed 323549@main (b934faaa9c95): <https://commits.webkit.org/323549@main>
Reviewed commits have been landed. Closing PR #76479 and removing active labels.