Bug 242585

Summary: Rewrite flaky document leak tests with testDocumentIsNotLeaked
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: DOMAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, rniwa, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Fujii Hironori
Reported 2022-07-10 20:21:39 PDT
Rewrite flaky document leak tests with testDocumentIsNotLeaked Some document leak tests are using internals.numberOfLiveDocuments() and flaky. Bug 146182 – editing/selection/leak-document-with-selection-inside.html is flaky Bug 190890 – [macOS Release WK1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure Bug 215177 – [ macOS iOS wk2 Release] editing/selection/navigation-clears-editor-state.html is a flaky failure Bug 226598 – [MacOS & iOS] animations/leak-document-with-css-animation.html is a flaky failure 224541@main added testDocumentIsNotLeaked for the document leak tests.
Attachments
Patch (22.87 KB, patch)
2022-07-10 20:28 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.87 KB, patch)
2022-07-12 00:51 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-07-10 20:28:46 PDT
Created attachment 460787 [details] Patch
Ryosuke Niwa
Comment 2 2022-07-11 21:21:47 PDT
Comment on attachment 460787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460787&action=review > LayoutTests/fast/workers/worker-document-leak.html:39 > + await waitForDoneMessage() Missing semicolon at the end.
Fujii Hironori
Comment 3 2022-07-12 00:51:43 PDT
Created attachment 460807 [details] Patch for landing
EWS
Comment 4 2022-07-12 02:28:11 PDT
Committed 252375@main (e0c7afc43de0): <https://commits.webkit.org/252375@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460807 [details].
Radar WebKit Bug Importer
Comment 5 2022-07-12 02:29:19 PDT
<rdar://problem/96872567>
David Kilzer (:ddkilzer)
Comment 6 2022-07-12 10:43:57 PDT
*** Bug 146182 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.