Bug 234980
| Summary: | Various RenderLayer issue with <dialog> | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 84635 | ||
Tim Nguyen (:ntim)
Why?
- Avoid a myriad of establishesTopLayer() checks over the place
- Avoids needing to think about top layer later on
Tasks:
- Make RenderLayer::addChild/updateLayerPosition and anything else that relies on renderer hierarchy
- Need to look into a bunch of new assertions
- Fix visibility code to not be affected by layer reparenting (DOM/flat tree hierarchy should be followed for visibility, like for display)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/87560426>
Simon Fraser (smfr)
These are the ancestor tree walks I've found that need thinking about in terms of top layer:
setAncestorChainHasSelfPaintingLayerDescendant
setAncestorChainHasVisibleDescendant
SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem
enclosingScrollableLayer()
RenderElement::moveLayers
RenderElement::findNextLayer
traverseAncestorLayers
enclosingFragmentedFlowAncestor
Simon Fraser (smfr)
I think all the examples above are taken care of by RenderLayer reparenting (fixed in bug 235194).
So the only remaining issue is an incorrect opacity computation in ContentChangeObserver::isVisuallyHidden() (bug 235240).
Simon Fraser (smfr)
Closing since this is covered by other bugs.