Bug 229312

Summary:

[build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, bugs-noreply, clopez, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229311

Attachments:

Description	Flags
Patch	none

Carlos Alberto Lopez Perez

Reported 2021-08-19 17:13:31 PDT

On bug 227744 a new tester was added, but this tester should only be running layout tests. It is not useful that this bots run other kind of tests like api tests, python tests or perl tests.

Attachments
Patch (4.07 KB, patch) 2021-08-19 17:43 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2021-08-19 17:43:45 PDT

Created attachment 435930 [details] Patch

Aakash Jain

Comment 2 2021-08-20 07:38:21 PDT

Comment on attachment 435930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:218 > +class TestLayoutFactory(Factory): Nit: better to call it LayoutTestFactory (even though the naming might not be good earlier, we can improve it now)

Aakash Jain

Comment 3 2021-08-20 07:42:08 PDT

Comment on attachment 435930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:225 > + self.addStep(RunDashboardTests()) Do you want to run dashboard tests on this queue?

Carlos Alberto Lopez Perez

Comment 4 2021-08-20 09:31:43 PDT

(In reply to Aakash Jain from comment #2) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:218 > > +class TestLayoutFactory(Factory): > > Nit: better to call it LayoutTestFactory (even though the naming might not > be good earlier, we can improve it now) That would be inconsistent with the other factory naming.. all are named either "TestSomethingFactory" or "BuildAndTestSomethingFactory"

Carlos Alberto Lopez Perez

Comment 5 2021-08-20 09:53:54 PDT

(In reply to Aakash Jain from comment #3) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:225 > > + self.addStep(RunDashboardTests()) > > Do you want to run dashboard tests on this queue? I think we do, for consistency, as far as I can see the dashboard tests runner simply calls run-webkit-tests over other directory than LayoutTests. So they seem to me like some kind of specialized layout tests.

Carlos Alberto Lopez Perez

Comment 6 2021-08-20 11:25:38 PDT

Committed r281327 (240744@main): <https://commits.webkit.org/240744@main>

Radar WebKit Bug Importer

Comment 7 2021-08-20 11:26:20 PDT

<rdar://problem/82178321>

Aakash Jain

Comment 8 2021-08-26 10:39:47 PDT

buildbot was restarted to pick up this change. Seems to be working, e.g.: https://build.webkit.org/#/builders/199/builds/951

Note You need to log in before you can comment on or make changes to this bug.