Bug 226658

Summary: [run-webkit-tests] Use Python 3
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, dewei_zhu, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225427
https://bugs.webkit.org/show_bug.cgi?id=227715
https://bugs.webkit.org/show_bug.cgi?id=221043
https://bugs.webkit.org/show_bug.cgi?id=229172
https://bugs.webkit.org/show_bug.cgi?id=229360
https://bugs.webkit.org/show_bug.cgi?id=229783
https://bugs.webkit.org/show_bug.cgi?id=237404
Bug Depends on: 230513    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Part 1
none
Patch
none
Run with 3 test
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Testing Patch
none
Part 2
none
Testing Patch
ews-feeder: commit-queue-
Testing Patch
ews-feeder: commit-queue-
Testing Patch
none
[fast-cq] Patch
none
[fast-cq] Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2021-06-04 13:03:54 PDT
Now that run-webkit-tests is compatible with Python 3.8, we should use Python 3 for run-webkit-tests.
Attachments
Patch (24.59 KB, patch)
2021-06-04 13:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Part 1 (1005 bytes, patch)
2021-06-30 10:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (24.09 KB, patch)
2021-06-30 11:09 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Run with 3 test (4.60 KB, patch)
2021-07-01 08:43 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2021-08-16 11:11 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2021-08-16 14:59 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Testing Patch (6.25 KB, patch)
2021-08-16 16:47 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Part 2 (26.27 KB, patch)
2021-08-17 08:32 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Testing Patch (5.12 KB, patch)
2021-08-17 15:33 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Testing Patch (5.60 KB, patch)
2021-08-18 10:42 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Testing Patch (17.51 KB, patch)
2021-08-20 17:42 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (7.91 KB, patch)
2021-08-26 09:14 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (20.29 KB, patch)
2021-08-26 09:16 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (26.36 KB, patch)
2021-09-24 17:04 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (26.35 KB, patch)
2021-09-24 17:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.11 KB, patch)
2022-02-09 16:55 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-04 13:04:29 PDT
<rdar://problem/78882016>
Jonathan Bedard
Comment 2 2021-06-04 13:08:59 PDT
Created attachment 430602 [details] Patch
Jonathan Bedard
Comment 3 2021-06-04 13:16:20 PDT
Probably needs to be tested at the same time as https://bugs.webkit.org/show_bug.cgi?id=225427, they are doing something very similar
Jonathan Bedard
Comment 4 2021-06-30 10:45:14 PDT
Created attachment 432609 [details] Part 1
Jonathan Bedard
Comment 5 2021-06-30 11:09:51 PDT
Created attachment 432612 [details] Patch
Jonathan Bedard
Comment 6 2021-07-01 08:43:55 PDT
Created attachment 432699 [details] Run with 3 test
Carlos Alberto Lopez Perez
Comment 7 2021-07-08 17:24:56 PDT
is this waiting for review? why not squash all the 3 commits into 1?
Aakash Jain
Comment 8 2021-07-09 08:21:29 PDT
(In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Nope. It's waiting for more testing.
Jonathan Bedard
Comment 9 2021-07-12 08:41:09 PDT
(In reply to Carlos Alberto Lopez Perez from comment #7) > is this waiting for review? why not squash all the 3 commits into 1? Just some clarification, the 3rd patch is not meant for landing, it's just a way for me to force EWS to use Python 3 since buildbot invokes run-webkit-tests with Python 2 directly.
Jonathan Bedard
Comment 10 2021-08-16 11:11:21 PDT
Created attachment 435620 [details] Patch
Jonathan Bedard
Comment 11 2021-08-16 14:59:36 PDT
Created attachment 435632 [details] Patch
Jonathan Bedard
Comment 12 2021-08-16 16:47:10 PDT
Created attachment 435643 [details] Testing Patch
Jonathan Bedard
Comment 13 2021-08-17 08:32:58 PDT
Created attachment 435689 [details] Part 2
Aakash Jain
Comment 14 2021-08-17 13:15:42 PDT
https://ews-build.webkit.org/#/builders/10/builds/101763 (windows) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 111, in command_for_printing return string_utils.decode(string_utils.encode(' '.join(args), encoding='unicode_escape')) TypeError: sequence item 0: expected str instance, bytes found
Jonathan Bedard
Comment 15 2021-08-17 15:33:05 PDT
Created attachment 435716 [details] Testing Patch
Jonathan Bedard
Comment 16 2021-08-18 10:42:36 PDT
Created attachment 435782 [details] Testing Patch
Jonathan Bedard
Comment 17 2021-08-20 17:42:56 PDT
Created attachment 436049 [details] Testing Patch
dewei_zhu
Comment 18 2021-08-24 16:02:52 PDT
Comment on attachment 432609 [details] Part 1 r=me
EWS
Comment 19 2021-08-24 16:39:20 PDT
Committed r281528 (240900@main): <https://commits.webkit.org/240900@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432609 [details].
Jonathan Bedard
Comment 20 2021-08-26 09:14:21 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 21 2021-08-26 09:14:22 PDT
Created attachment 436518 [details] [fast-cq] Patch
Jonathan Bedard
Comment 22 2021-08-26 09:16:28 PDT
Created attachment 436519 [details] [fast-cq] Patch
EWS
Comment 23 2021-08-26 09:25:27 PDT
Committed r281627 (240983@main): <https://commits.webkit.org/240983@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436518 [details].
Aakash Jain
Comment 24 2021-08-27 02:35:36 PDT
.
Aakash Jain
Comment 25 2021-08-27 02:36:16 PDT
Reopened for landing attachment 436519 [details].
EWS
Comment 26 2021-08-27 02:40:29 PDT
Committed r281690 (241040@main): <https://commits.webkit.org/241040@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436519 [details].
Aakash Jain
Comment 27 2021-08-27 04:20:40 PDT
buildbot on EWS and build.webkit.org has been restarted to pick up this change.
Jonathan Bedard
Comment 28 2021-09-24 17:03:24 PDT
Blocked by https://bugs.webkit.org/show_bug.cgi?id=230513, as it turns out.
Jonathan Bedard
Comment 29 2021-09-24 17:04:11 PDT
Created attachment 439214 [details] Patch
Jonathan Bedard
Comment 30 2021-09-24 17:08:57 PDT
Created attachment 439216 [details] Patch
EWS
Comment 31 2021-09-24 17:46:11 PDT
Committed r283071 (242129@main): <https://commits.webkit.org/242129@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439216 [details].
Jonathan Bedard
Comment 32 2021-09-29 08:27:24 PDT
Blocked by https://bugs.webkit.org/show_bug.cgi?id=230513 at the moment
Jonathan Bedard
Comment 33 2022-02-09 16:55:55 PST
Created attachment 451466 [details] Patch
Jonathan Bedard
Comment 34 2022-02-17 17:27:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/160
Jonathan Bedard
Comment 35 2022-02-21 07:25:13 PST
Landed https://commits.webkit.org/247569@main (r290244)!
Jonathan Bedard
Comment 36 2022-02-22 13:20:45 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/165
Jonathan Bedard
Comment 37 2022-02-22 13:50:16 PST
Pull request: https://github.com/WebKit/WebKit/pull/167
Jonathan Bedard
Comment 38 2022-02-24 07:13:46 PST
Landed https://commits.webkit.org/247736@main (r290429)!
Note You need to log in before you can comment on or make changes to this bug.