Bug 226617

Summary:

[Python-3] Change shebangs in JSC/inspector/scripts to Python 3

Product:

WebKit

Reporter:

hysu <hysu>

Component:

Tools / Tests

Assignee:

hysu <hysu>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, bburg, ews-watchlist, hi, hysu, jbedard, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229574

Bug Depends on:

Bug Blocks:

226631

Attachments:

Description	Flags
Patch	none

hysu

Reported 2021-06-03 18:05:12 PDT

Breaking up an effort to make Python scripts in the JSC build process use Python 3 by default into multiple patches. This patch addresses the ./inspector/scripts/ directory.

Attachments
Patch (19.11 KB, patch) 2021-06-03 18:54 PDT, hysu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

hysu

Comment 1 2021-06-03 18:54:31 PDT

Created attachment 430530 [details] Patch

Radar WebKit Bug Importer

Comment 2 2021-06-03 18:54:56 PDT

<rdar://problem/78848866>

EWS Watchlist

Comment 3 2021-06-03 18:55:15 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

hysu

Comment 4 2021-06-03 18:56:08 PDT

(Submitting this patch first as --no-review to see if it gets past EWS)

Jonathan Bedard

Comment 5 2021-06-04 12:16:49 PDT

Comment on attachment 430530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430530&action=review > Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:1 > +#!/usr/bin/env python3 Make sure that we cover any callers of these too, which may be calling via "python Source...."

Jonathan Bedard

Comment 6 2021-06-04 12:20:17 PDT

Comment on attachment 430530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430530&action=review > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:1 > +#!/usr/bin/env python3 Looks like this is the root script, we need to make sure it's callers are invoking it with Python3

Sam Sneddon [:gsnedders]

Comment 7 2023-08-31 05:49:54 PDT

*** This bug has been marked as a duplicate of bug 231587 ***

Note You need to log in before you can comment on or make changes to this bug.