Bug 22615

Summary: LayoutTests/video-aspect-ratio.html renders with a different brightness if Perian 1.1 is installed
Product: WebKit Reporter: Pierre-Olivier Latour <pol>
Component: Tools / TestsAssignee: Pierre-Olivier Latour <pol>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, mitz
Priority: P4 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 21911    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 darin: review+

Pierre-Olivier Latour
Reported 2008-12-02 19:36:59 PST
LayoutTests/video-aspect-ratio.html renders with a different brightness if Perian 1.1 is installed This makes several <video> layout test fail when running in --pixel mode.
Attachments
Patch v1 (2.06 KB, patch)
2009-01-20 15:08 PST, Pierre-Olivier Latour 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1 2008-12-02 19:40:24 PST
This is actually affecting all the tests that use the test.mp4 video: 320x240 H264 What's interesting is that in QT Player, it doesn't seem to open with Perian (info pane doesn't mention Perian), while in WebKit it certainly is.
Pierre-Olivier Latour
Comment 2 2008-12-03 09:01:58 PST
Now in Radar: <rdar://problem/6414887> LayoutTests/video-aspect-ratio.html renders with a different brightness if Perian 1.1 is installed
Pierre-Olivier Latour
Comment 3 2009-01-04 10:31:41 PST
This is a 3rd party issue: the culprit is Perian which _on purpose_ pretends to be QT H264 codec, so it gets picked up and the rendering differs.
Pierre-Olivier Latour
Comment 4 2009-01-20 15:04:53 PST
Following Darin's suggestion, run-webkit-tests should fail in --pixel mode if Perian is installed.
Pierre-Olivier Latour
Comment 5 2009-01-20 15:08:07 PST
Created attachment 26873 [details] Patch v1
Darin Adler
Comment 6 2009-01-20 15:21:33 PST
Comment on attachment 26873 [details] Patch v1 r=me
Pierre-Olivier Latour
Comment 7 2009-01-20 15:25:27 PST
Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/run-webkit-tests Sending WebKitTools/Scripts/webkitdirs.pm Transmitting file data ... Committed revision 40073.
Pierre-Olivier Latour
Comment 8 2009-01-21 17:31:15 PST
Needs to tweak the fix following Hyatt's comments
Pierre-Olivier Latour
Comment 9 2009-01-21 17:39:29 PST
Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/run-webkit-tests Transmitting file data .. Committed revision 40105.
Pierre-Olivier Latour
Comment 10 2009-01-26 13:45:44 PST
One more time: Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/run-webkit-tests Transmitting file data .. Committed revision 40256.
Note You need to log in before you can comment on or make changes to this bug.