Bug 221895

Summary: [selectors] :focus-visible parsing and experimental flag
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 185859, 234019    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2021-02-15 03:15:20 PST
[selectors] :focus-visible parsing and experimental flag
Attachments
Patch (13.67 KB, patch)
2021-02-15 03:16 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (42.90 KB, patch)
2021-02-15 04:40 PST, Manuel Rego Casasnovas 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (45.58 KB, patch)
2021-02-15 09:09 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (45.53 KB, patch)
2021-02-16 11:18 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (45.53 KB, patch)
2021-02-16 11:29 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2021-02-15 03:16:06 PST
Created attachment 420299 [details] Patch
Manuel Rego Casasnovas
Comment 2 2021-02-15 04:40:33 PST
Created attachment 420307 [details] Patch
Manuel Rego Casasnovas
Comment 3 2021-02-15 09:09:21 PST
Created attachment 420321 [details] Patch
Manuel Rego Casasnovas
Comment 4 2021-02-15 12:57:26 PST
EWSs are green or have unrelated failures, I believe this is ready for review. PTAL.
Darin Adler
Comment 5 2021-02-16 10:21:05 PST
Comment on attachment 420321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420321&action=review > Source/WebCore/css/SelectorCheckerTestFunctions.h:480 > + if (InspectorInstrumentation::forcePseudoState(element, CSSSelector::PseudoClassFocusVisible)) > + return true; > + > + return false; Should just be a return statement, no need for if true else false. > LayoutTests/imported/w3c/ChangeLog:8 > + Update expectations as now :focus-visible is a valid selector. Is this because the feature is on for regression tests? Or do these changes happen with the feature still off? If the latter, I am worried that even these small changes could cause compatibility problems.
Manuel Rego Casasnovas
Comment 6 2021-02-16 11:15:07 PST
Comment on attachment 420321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420321&action=review Thanks for the review. >> Source/WebCore/css/SelectorCheckerTestFunctions.h:480 >> + return false; > > Should just be a return statement, no need for if true else false. True, changed that. >> LayoutTests/imported/w3c/ChangeLog:8 >> + Update expectations as now :focus-visible is a valid selector. > > Is this because the feature is on for regression tests? Or do these changes happen with the feature still off? > > If the latter, I am worried that even these small changes could cause compatibility problems. AFAIK the experimental feature flags are enabled by default for tests, but not when you run minibrowser for example.
Manuel Rego Casasnovas
Comment 7 2021-02-16 11:18:02 PST
Created attachment 420504 [details] Patch
Manuel Rego Casasnovas
Comment 8 2021-02-16 11:29:54 PST
Created attachment 420510 [details] Patch
EWS
Comment 9 2021-02-16 21:54:20 PST
Committed r272983: <https://commits.webkit.org/r272983> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420510 [details].
Radar WebKit Bug Importer
Comment 10 2021-02-16 21:55:13 PST
<rdar://problem/74421155>
Note You need to log in before you can comment on or make changes to this bug.