Bug 221280

Summary: [build.webkit.org] Update dashboard links for layout test results
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, lingho, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221822
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2021-02-02 12:15:06 PST
In https://trac.webkit.org/r271801, we stopped hosting results on build.webkit.org (upcoming instance). Instead we are hosting results on S3. We should update dashboard to fetch the results from S3.
Attachments
Patch (3.66 KB, patch)
2021-02-03 07:44 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (3.66 KB, patch)
2021-02-04 14:39 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-02-03 07:44:03 PST
Created attachment 419136 [details] Patch
Jonathan Bedard
Comment 2 2021-02-03 11:49:34 PST
Comment on attachment 419136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review > Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200 > + url = this.baseURLForResults; This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean
Jonathan Bedard
Comment 3 2021-02-03 13:59:35 PST
Comment on attachment 419136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review >> Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200 >> + url = this.baseURLForResults; > > This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean Ok, I see what we're doing here, but I'm not sure this is the clearest way to express this. Can we change `this.baseURLForResults = options && options.baseURLForResults` to `this.baseURLForResults = options ? options.baseURLForResults : null`
Aakash Jain
Comment 4 2021-02-04 14:39:33 PST
Created attachment 419325 [details] Patch
EWS
Comment 5 2021-02-04 15:47:13 PST
commit-queue failed to commit attachment 419325 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 6 2021-02-04 16:55:13 PST
Committed r272399: <https://trac.webkit.org/changeset/272399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419325 [details].
Radar WebKit Bug Importer
Comment 7 2021-02-04 16:56:13 PST
<rdar://problem/74003748>
Note You need to log in before you can comment on or make changes to this bug.