Bug 220312

Summary:

[selectors] Update tests from WPT

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, ews-watchlist, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220578

Bug Depends on:

220243

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Manuel Rego Casasnovas

Reported 2021-01-05 02:03:24 PST

:focus-visible tests in WPT have been improved recently, we need to re-import them. We'll be able to unskip them as they have now the same failure output for all platforms.

Attachments
Patch (68.29 KB, patch) 2021-01-05 02:37 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (68.69 KB, patch) 2021-01-06 21:39 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (69.50 KB, patch) 2021-01-06 22:43 PST, Manuel Rego Casasnovas	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (69.69 KB, patch) 2021-01-07 02:14 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (70.13 KB, patch) 2021-01-08 01:38 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (71.11 KB, patch) 2021-01-11 03:13 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (72.63 KB, patch) 2021-01-11 03:57 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (72.97 KB, patch) 2021-01-11 06:32 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (79.97 KB, patch) 2021-01-11 22:50 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2021-01-05 02:37:41 PST

Created attachment 416981 [details] Patch

Manuel Rego Casasnovas

Comment 2 2021-01-06 21:39:01 PST

Created attachment 417153 [details] Patch

Manuel Rego Casasnovas

Comment 3 2021-01-06 22:43:11 PST

Created attachment 417156 [details] Patch

Manuel Rego Casasnovas

Comment 4 2021-01-07 02:14:28 PST

Created attachment 417171 [details] Patch

Manuel Rego Casasnovas

Comment 5 2021-01-08 01:38:25 PST

Created attachment 417256 [details] Patch

Manuel Rego Casasnovas

Comment 6 2021-01-11 03:13:48 PST

Created attachment 417366 [details] Patch

Manuel Rego Casasnovas

Comment 7 2021-01-11 03:57:57 PST

Created attachment 417370 [details] Patch

Manuel Rego Casasnovas

Comment 8 2021-01-11 06:32:18 PST

Created attachment 417375 [details] Patch

Manuel Rego Casasnovas

Comment 9 2021-01-11 22:50:15 PST

Created attachment 417436 [details] Patch

Manuel Rego Casasnovas

Comment 10 2021-01-12 00:45:57 PST

Comment on attachment 417436 [details] Patch EWSs are green now. Some tests are skipped as they timeout in Apple platforms, I'll investigate them and look for a solution. But so far we can update the test suite IMHO.

Sergio Villar Senin

Comment 11 2021-01-12 00:52:07 PST

Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review > LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:12 > +appearance Not sure what this is about... > LayoutTests/platform/glib/TestExpectations:199 > +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here?

Manuel Rego Casasnovas

Comment 12 2021-01-12 00:57:43 PST

Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review Thanks for the review. >> LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:12 >> +appearance > > Not sure what this is about... This is added automatically by the importer. One of the tests use "apperance" property, which in WebKit is only supported as "-webkit-apperance". So the script renames the property and note down it here. >> LayoutTests/platform/glib/TestExpectations:199 >> +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] > > Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here? Is there a single file to skip them for both Mac and iOS? Or I'd need to skip them in both files?

Radar WebKit Bug Importer

Comment 13 2021-01-12 02:04:17 PST

<rdar://problem/73032760>

Manuel Rego Casasnovas

Comment 14 2021-01-12 02:39:30 PST

Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review >>> LayoutTests/platform/glib/TestExpectations:199 >>> +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] >> >> Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here? > > Is there a single file to skip them for both Mac and iOS? Or I'd need to skip them in both files? After talking with Sergio off-line, he's fine with landing this as is so far, as more work related to these tests is going to be done when implementing :focus-visible.

EWS

Comment 15 2021-01-12 02:42:31 PST

Committed r271395: <https://trac.webkit.org/changeset/271395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417436 [details].

Note You need to log in before you can comment on or make changes to this bug.