Bug 219012

Summary: [macOS] Only extend access to the AppleIntelMEUserClient IOKit class if the GPU Process is not used
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, pvollan, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210616
Bug Depends on:    
Bug Blocks: 219014    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Brent Fulgham
Reported 2020-11-16 16:27:48 PST
Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Attachments
Patch (2.44 KB, patch)
2020-11-16 16:29 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, text/plain)
2020-11-16 19:12 PST, Brent Fulgham 		no flags
Details
Patch (2.89 KB, patch)
2020-12-02 15:41 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (7.48 KB, patch)
2020-12-02 16:00 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (7.47 KB, patch)
2020-12-02 16:02 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-11-16 16:28:02 PST
<rdar://problem/70462796>
Brent Fulgham
Comment 2 2020-11-16 16:29:59 PST
Created attachment 414290 [details] Patch
EWS
Comment 3 2020-11-16 19:06:09 PST
Committed r269890: <https://trac.webkit.org/changeset/269890> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414290 [details].
Brent Fulgham
Comment 4 2020-11-16 19:12:52 PST
Reopening to attach new patch.
Brent Fulgham
Comment 5 2020-11-16 19:12:53 PST
Created attachment 414300 [details] Patch
Brent Fulgham
Comment 6 2020-11-16 19:13:46 PST
Ignore the above.
Truitt Savell
Comment 7 2020-11-17 15:03:23 PST
It looks like the changes in https://trac.webkit.org/changeset/269890/webkit has broken platform/mac/media/encrypted-media/fps-generateRequest.html on Catalina wk2 History: https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac%2Fmedia%2Fencrypted-media%2Ffps-generateRequest.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-actual.txt @@ -6,6 +6,6 @@ RUN(session = keys.createSession()) EXPECTED (session != 'null') OK RUN(promise = session.generateRequest("sinf", initData)) -Promise resolved OK +Promise rejected FAIL END OF TEST
Brent Fulgham
Comment 8 2020-11-18 14:54:57 PST
(In reply to Truitt Savell from comment #7) > It looks like the changes in https://trac.webkit.org/changeset/269890/webkit > > has broken platform/mac/media/encrypted-media/fps-generateRequest.html on > Catalina wk2 > I'll look into it now. I'm building a local root on Catalina to test. These tests do pass on Big Sur, so I might just need to tighten the version check.
Brent Fulgham
Comment 9 2020-11-19 13:48:02 PST
I cannot reproduce this failure on a Release Intel MacBook Pro on Catalina, or an Intel MacPro on Big Sur. Perhaps this is hardware-specific.
Brent Fulgham
Comment 10 2020-11-19 14:07:41 PST
Given that some Intel CPU's require this access to support encrypted media playback, we should extend this dynamically to WebContent if we are not using the GPU Process, and always grant it in the GPU Process.
Brent Fulgham
Comment 11 2020-11-19 17:12:49 PST
Committed r270061: <https://trac.webkit.org/changeset/270061>
Brent Fulgham
Comment 12 2020-11-19 17:13:09 PST
(In reply to Brent Fulgham from comment #11) > Committed r270061: <https://trac.webkit.org/changeset/270061> I rolled out this bug in the above patch.
Brent Fulgham
Comment 13 2020-12-02 15:41:30 PST
Created attachment 415254 [details] Patch
Brent Fulgham
Comment 14 2020-12-02 16:00:36 PST
Created attachment 415257 [details] Patch
Brent Fulgham
Comment 15 2020-12-02 16:02:15 PST
Created attachment 415258 [details] Patch
Brent Fulgham
Comment 16 2020-12-02 16:03:15 PST
Comment on attachment 415258 [details] Patch Patch was reviewed by Eric Carlson. I'm flagging an updated patch that he reviewed online with me.
EWS
Comment 17 2020-12-02 17:41:18 PST
Committed r270381: <https://trac.webkit.org/changeset/270381> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415258 [details].
Note You need to log in before you can comment on or make changes to this bug.