Bug 218805

Summary: [build.webkit.org] Update RunWebKitTests step for new buildbot
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: dean_johnson, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218907
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-11-11 08:49:31 PST
We are planning to upgrade build.webkit.org to latest Buildbot. We should update RunWebKitTests as per new Buildbot, e.g.: use logobserver instead of cmd.logs['stdio'].getText() use getResultSummary instead of getText/getText2 Also we should take this opportunity to switch to logobserver.LineConsumerLogObserver which is more efficient in processing large logs than logobserver.BufferLogObserver.
Attachments
Patch (7.33 KB, patch)
2020-11-11 08:54 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (7.97 KB, patch)
2020-11-11 09:30 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-11-11 08:54:48 PST
Created attachment 413826 [details] Patch
Aakash Jain
Comment 2 2020-11-11 08:55:55 PST
(In reply to Aakash Jain from comment #1) > Created attachment 413826 [details] > Patch Most of this code is copied from code written by Dean in another repository.
Jonathan Bedard
Comment 3 2020-11-11 09:04:58 PST
Comment on attachment 413826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413826&action=review > Tools/ChangeLog:10 > + (RunWebKitTests): Can we populate this changelog with a bit more information? > Tools/CISupport/build-webkit-org/steps.py:48 > + logobserver = lambda: None Were we not using the log observer previously? Or does that option not exist for buildbot 0.8?
Aakash Jain
Comment 4 2020-11-11 09:29:39 PST
(In reply to Jonathan Bedard from comment #3) > > Tools/CISupport/build-webkit-org/steps.py:48 > > + logobserver = lambda: None > > Were we not using the log observer previously? Or does that option not exist for buildbot 0.8? Yeah, Buildbot 0.8 didn't had this logobserver module.
Aakash Jain
Comment 5 2020-11-11 09:30:31 PST
Created attachment 413829 [details] Patch
EWS
Comment 6 2020-11-11 10:28:14 PST
Committed r269689: <https://trac.webkit.org/changeset/269689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413829 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-11 10:29:16 PST
<rdar://problem/71288809>
Dean Johnson
Comment 8 2020-11-11 13:16:54 PST
Looks good to me; unofficial r+.
Note You need to log in before you can comment on or make changes to this bug.