Bug 218692

Summary:

Implement the imperative slotting API

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annevk, chi187, emilio, mike, sam, tetsuharu.ohzeki, webkit-bug-importer, westbrook.johnson

Priority:

Keywords:

InRadar

Version:

Safari 12

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

219261, 220768, 242376, 242379, 243460, 243634, 243635, 243649, 243654, 243655, 243772, 243815, 243817, 243860, 243867, 243869, 243923

Bug Blocks:

148695

Attachments:

Description	Flags
wip	none
wip	none
Alternative WIP	none
WIP	none
WIP	none

Ryosuke Niwa

Reported 2020-11-07 20:51:58 PST

See https://github.com/whatwg/html/pull/5483 https://github.com/whatwg/dom/pull/860

Attachments
wip (28.25 KB, patch) 2020-11-23 10:34 PST, Tetsuharu Ohzeki [UTC+9]	no flags	Details Formatted Diff Diff
wip (34.03 KB, patch) 2022-03-02 07:31 PST, Tetsuharu Ohzeki [UTC+9]	no flags	Details Formatted Diff Diff
Alternative WIP (40.67 KB, patch) 2022-03-02 22:10 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
WIP (27.37 KB, patch) 2022-08-08 02:18 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
WIP (11.31 KB, patch) 2022-08-08 02:42 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tetsuharu Ohzeki [UTC+9]

Comment 1 2020-11-08 00:32:03 PST

May I take this? ———— When we start to implement this, should we add an experimental flag for this?

Sam Weinig

Comment 2 2020-11-08 10:17:47 PST

(In reply to Tetsuharu Ohzeki [UTC+9] from comment #1) > May I take this? > > ———— > > When we start to implement this, should we add an experimental flag for this? You may! Please do! Yeah, adding an experimental flag to Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml would be a great thing to do for this. Please let us know if you have any questions.

Anne van Kesteren

Comment 3 2020-11-09 03:37:03 PST

(If one of you could also do another pass over those PRs against DOM and HTML, perhaps after the latest round of feedback is addressed, that would be terrific. I'm afraid I'm starting to miss the bigger picture due to the long review cycles.)

Radar WebKit Bug Importer

Comment 4 2020-11-14 20:52:17 PST

<rdar://problem/71407958>

Tetsuharu Ohzeki [UTC+9]

Comment 5 2020-11-23 10:34:39 PST

Created attachment 414807 [details] wip

Ryosuke Niwa

Comment 6 2021-09-16 17:47:03 PDT

References: https://github.com/whatwg/html/pull/6561/files https://github.com/whatwg/dom/pull/966/files

Westbrook

Comment 7 2022-02-18 16:46:42 PST

With this fully landed in Chrome and Firefox, any word on prioritization for bringing this to WebKit?

Tetsuharu Ohzeki [UTC+9]

Comment 8 2022-03-02 07:31:14 PST

Created attachment 453608 [details] wip

Ryosuke Niwa

Comment 9 2022-03-02 22:10:28 PST

Created attachment 453697 [details] Alternative WIP

Ryosuke Niwa

Comment 10 2022-08-08 02:18:48 PDT

Created attachment 461478 [details] WIP

Ryosuke Niwa

Comment 11 2022-08-08 02:42:43 PDT

Created attachment 461479 [details] WIP The most basic aspect of the feature works with this WIP.

Ryosuke Niwa

Comment 12 2022-08-08 02:57:22 PDT

(In reply to Ryosuke Niwa from comment #10) > Created attachment 461478 [details] > WIP hm... on my second thought, this approach doesn't quite work. I was trying to avoid having a dedicated back reference from a Node to its manually assigned slot but I don't think there is a way around it. When a slot that's outside "this" shadow tree is assigned of a node that had previously been assigned to another slot in "this" shadow tree, we still need to sever the slot assignment but we won't be able to find the slot without having some kind of a back reference from the node to its manually assigned slot. So we probably need a new member in NodeRareData which is about back reference from a Node to its manually assigned slot. It kind of stinks that we have to use NodeRareData for this.

Ryosuke Niwa

Comment 13 2022-08-12 18:01:39 PDT

This feature is basically complete. We just need to enable it by default everywhere.

Tetsuharu Ohzeki [UTC+9]

Comment 14 2022-08-13 00:31:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3290

EWS

Comment 15 2022-08-13 02:13:02 PDT

Committed 253402@main (80742bc96322): <https://commits.webkit.org/253402@main> Reviewed commits have been landed. Closing PR #3290 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.