Bug 215901

Summary: Update PannerNode to support k-rate automation of its AudioParams
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215946
Bug Depends on: 215904    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-08-27 13:31:09 PDT
Update PannerNode to support k-rate automation of its AudioParams.
Attachments
Patch (189.04 KB, patch)
2020-08-28 10:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (189.03 KB, patch)
2020-08-28 10:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (189.03 KB, patch)
2020-08-28 11:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (189.06 KB, patch)
2020-08-28 11:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (187.71 KB, patch)
2020-08-28 15:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (163.39 KB, patch)
2020-08-28 16:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (163.47 KB, patch)
2020-08-28 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (163.47 KB, patch)
2020-08-28 17:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-28 10:25:12 PDT
Created attachment 407480 [details] Patch
Chris Dumez
Comment 2 2020-08-28 10:52:58 PDT
Created attachment 407486 [details] Patch
Chris Dumez
Comment 3 2020-08-28 11:23:38 PDT
Created attachment 407487 [details] Patch
Chris Dumez
Comment 4 2020-08-28 11:57:11 PDT
Created attachment 407492 [details] Patch
Chris Dumez
Comment 5 2020-08-28 15:00:48 PDT
Created attachment 407504 [details] Patch
Chris Dumez
Comment 6 2020-08-28 15:52:16 PDT
Comment on attachment 407504 [details] Patch Trying to see if I can simplify the patch a bit by leaving the caching out.
Chris Dumez
Comment 7 2020-08-28 16:51:54 PDT
Created attachment 407515 [details] Patch
Chris Dumez
Comment 8 2020-08-28 16:55:59 PDT
Created attachment 407516 [details] Patch
Chris Dumez
Comment 9 2020-08-28 16:56:42 PDT
(In reply to Chris Dumez from comment #8) > Created attachment 407516 [details] > Patch Ok, got the patch as small as I could.
Darin Adler
Comment 10 2020-08-28 17:05:26 PDT
Comment on attachment 407516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407516&action=review > Source/WebCore/Modules/webaudio/AudioParam.cpp:277 > + for (unsigned i = 0; i < numberOfValues; ++i) I suggest starting with 1 so we don’t do values[0] = values[0]. > Source/WebCore/Modules/webaudio/PannerNode.cpp:501 > + double azimuth = rad2deg(acos(std::clamp(projectedSource.dot(listenerRight), -1.0f, 1.0f))); std::rad2deg, std::acos
Chris Dumez
Comment 11 2020-08-28 17:45:04 PDT
(In reply to Darin Adler from comment #10) > Comment on attachment 407516 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407516&action=review > > > Source/WebCore/Modules/webaudio/AudioParam.cpp:277 > > + for (unsigned i = 0; i < numberOfValues; ++i) > > I suggest starting with 1 so we don’t do values[0] = values[0]. > > > Source/WebCore/Modules/webaudio/PannerNode.cpp:501 > > + double azimuth = rad2deg(acos(std::clamp(projectedSource.dot(listenerRight), -1.0f, 1.0f))); > > std::rad2deg, std::acos rad2deg is from MathExtras.h. Will fix acos.
Chris Dumez
Comment 12 2020-08-28 17:47:13 PDT
Created attachment 407520 [details] Patch
EWS
Comment 13 2020-08-28 19:32:42 PDT
Committed r266319: <https://trac.webkit.org/changeset/266319> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407520 [details].
Radar WebKit Bug Importer
Comment 14 2020-08-28 19:33:17 PDT
<rdar://problem/67975302>
Note You need to log in before you can comment on or make changes to this bug.