Bug 215616

Summary: [WebGL2] Various parameters should be non-nullable in IDL
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, joepeck, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

James Darpinian
Reported 2020-08-18 11:10:42 PDT
[WebGL2] Various parameters should be non-nullable in IDL
Attachments
Patch (69.70 KB, patch)
2020-08-18 11:13 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (95.95 KB, patch)
2020-08-18 14:55 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (108.68 KB, patch)
2020-08-18 15:26 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (120.88 KB, patch)
2020-08-18 16:01 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-08-18 11:13:54 PDT
Created attachment 406794 [details] Patch
Kenneth Russell
Comment 2 2020-08-18 14:34:40 PDT
Comment on attachment 406794 [details] Patch The patch looks good but some tests are failing. Could you resolve those failures and ping when there's a new patch up? Thanks.
James Darpinian
Comment 3 2020-08-18 14:55:43 PDT
Created attachment 406815 [details] Patch
James Darpinian
Comment 4 2020-08-18 15:26:20 PDT
Created attachment 406818 [details] Patch
James Darpinian
Comment 5 2020-08-18 15:27:59 PDT
Lots of wrong and broken tests needed fixing. I think this patch should pass now.
Darin Adler
Comment 6 2020-08-18 15:35:20 PDT
Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review > LayoutTests/ChangeLog:17 > + * fast/canvas/webgl/context-lost-expected.txt: > + * fast/canvas/webgl/context-lost.html: > + * fast/canvas/webgl/error-reporting-expected.txt: > + * fast/canvas/webgl/error-reporting.html: > + * fast/canvas/webgl/get-active-test-expected.txt: > + * fast/canvas/webgl/get-active-test.html: > + * fast/canvas/webgl/gl-object-get-calls-expected.txt: > + * fast/canvas/webgl/gl-object-get-calls.html: > + * fast/canvas/webgl/null-object-behaviour-expected.txt: > + * fast/canvas/webgl/null-object-behaviour.html: If any of these are redundant tests, you should feel free to cut them down.
Darin Adler
Comment 7 2020-08-18 15:35:48 PDT
Oops, I didn’t wait long enough to see if the tests pass. Please don’t land until you know they pass.
Kenneth Russell
Comment 8 2020-08-18 15:38:25 PDT
Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review Fantastic work James! One question. > LayoutTests/fast/canvas/webgl/error-reporting.html:-21 > -// synthetic GL errors. This test verifies the raising of certain Was the removal of this part of the comment intentional?
James Darpinian
Comment 9 2020-08-18 15:48:21 PDT
Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review >> LayoutTests/ChangeLog:17 >> + * fast/canvas/webgl/null-object-behaviour.html: > > If any of these are redundant tests, you should feel free to cut them down. Thanks, yes, they are redundant to some in webgl/1.0.3 and webgl/2.0.0. Next time I'll try deleting redundant tests instead of attempting to fix them. >> LayoutTests/fast/canvas/webgl/error-reporting.html:-21 >> -// synthetic GL errors. This test verifies the raising of certain > > Was the removal of this part of the comment intentional? You're right, this was unintentional.
James Darpinian
Comment 10 2020-08-18 15:55:51 PDT
Comment on attachment 406818 [details] Patch Looks like I missed rebaselining two tests.
James Darpinian
Comment 11 2020-08-18 16:01:25 PDT
Created attachment 406820 [details] Patch
Kenneth Russell
Comment 12 2020-08-18 16:18:28 PDT
Comment on attachment 406820 [details] Patch Looks good! r+
EWS
Comment 13 2020-08-18 16:49:28 PDT
Committed r265841: <https://trac.webkit.org/changeset/265841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406820 [details].
Radar WebKit Bug Importer
Comment 14 2020-08-18 16:50:15 PDT
<rdar://problem/67362134>
Note You need to log in before you can comment on or make changes to this bug.