Bug 212229
| Summary: | Clean up HTMLVideoElement::VideoPresentationMode and HTMLMediaElementEnums::VideoFullscreenMode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> |
| Component: | Media | Assignee: | Peng Liu <peng.liu6> |
| Status: | NEW | ||
| Severity: | Normal | CC: | eric.carlson, fred.wang, jer.noble |
| Priority: | P2 | ||
| Version: | Safari 13 | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Peng Liu
We may not need both of them.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
These are defined here
https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLVideoElement.h#104
https://searchfox.org/wubkat/rev/c0a5af9c209ddfdb7f9426089d9ac3d9b118cecb/Source/WebCore/platform/graphics/MediaPlayerEnums.h#148
One is an enum the other is a bit field. Not sure what's the proposed refactoring (use something like WTF::BitSet on HTMLVideoElement::VideoPresentationMode ?) and whether that's still wanted.