Bug 210617

Summary: [css-grid] Revert "Exclude implicit tracks from grid-template-rows/columns resolved values"
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, kondapallykalyan, macpherson, menard, pdr, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204588    
Attachments:
Description Flags
Patch none

Oriol Brufau
Reported 2020-04-16 13:25:55 PDT
The change from bug 204588 has been reverted in Chromium and Firefox because it appears to be breaking site authoring tools which were relying on the previous behaviour. https://bugs.chromium.org/p/chromium/issues/detail?id=1069866 https://bugzilla.mozilla.org/show_bug.cgi?id=1627347
Attachments
Patch (113.32 KB, patch)
2020-04-16 13:33 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2020-04-16 13:33:03 PDT
Created attachment 396694 [details] Patch
Manuel Rego Casasnovas
Comment 2 2020-04-16 23:51:30 PDT
Comment on attachment 396694 [details] Patch Thanks for taking care of the revert. r=me
EWS
Comment 3 2020-04-17 07:46:57 PDT
Committed r260249: <https://trac.webkit.org/changeset/260249> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396694 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-17 07:47:11 PDT
<rdar://problem/61934594>
Note You need to log in before you can comment on or make changes to this bug.