Bug 209788

Summary: Update to new Data Detectors SPI
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226227    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2020-03-30 16:02:42 PDT
Update to new Data Detectors SPI
Attachments
Patch (5.52 KB, patch)
2020-03-30 16:05 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (5.59 KB, patch)
2020-03-30 16:06 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.31 KB, patch)
2020-03-30 17:24 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.41 KB, patch)
2020-03-30 17:28 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-03-30 16:05:05 PDT
Created attachment 394978 [details] Patch
Megan Gardner
Comment 2 2020-03-30 16:06:11 PDT
Created attachment 394979 [details] Patch
Megan Gardner
Comment 3 2020-03-30 16:06:36 PDT
<rdar://problem/60690050>
Darin Adler
Comment 4 2020-03-30 16:34:31 PDT
Comment on attachment 394979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394979&action=review Is this OK all the way back to Mojave? > Source/WebCore/page/mac/ServicesOverlayController.mm:519 > + RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, &cgRect, 1, mainFrameView.visibleContentRect(), DDHighlightStyleBubbleStandard | DDHighlightStyleStandardIconArrow, YES, NSWritingDirectionNatural, NO, YES, 0)); Might be nicer to use auto here. > Source/WebCore/page/mac/ServicesOverlayController.mm:561 > + RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, cgRects.begin(), cgRects.size(), visibleRect, DDHighlightStyleBubbleNone | DDHighlightStyleStandardIconArrow | DDHighlightStyleButtonShowAlways, YES, NSWritingDirectionNatural, NO, YES, 0)); Ditto.
Megan Gardner
Comment 5 2020-03-30 17:24:31 PDT
Created attachment 394990 [details] Patch
Megan Gardner
Comment 6 2020-03-30 17:28:37 PDT
Created attachment 394991 [details] Patch
EWS
Comment 7 2020-03-30 20:12:17 PDT
Committed r259276: <https://trac.webkit.org/changeset/259276> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394991 [details].
Note You need to log in before you can comment on or make changes to this bug.