Bug 209366

Summary: Web Inspector: REGRESSION(r257380, r257759): focusing the inspected page when docked dims most of the interface
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 204627, 207968    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-03-20 15:53:45 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. dock Web Inspector 3. click anywhere in the inspected page => the Web Inspector tab bar dims This should only happen when detached. We should only be dimming certain selected items, like `WI.TreeElement` or `WI.DataGridNode`. # STEPS TO REPRODUCE: 1. inspect any page 2. dock Web Inspector 3. select any node in the Elements Tab 4. click anywhere in the inspected page => the selected node from step #3 doesn't dim
Attachments
Patch (38.51 KB, patch)
2020-03-20 16:06 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (44.11 KB, patch)
2020-03-20 17:04 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-03-20 16:06:03 PDT
Created attachment 394146 [details] Patch
Nikita Vasilyev
Comment 2 2020-03-20 16:20:24 PDT
Comment on attachment 394146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394146&action=review Thank you for fixing these. > Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.css:44 > +.tree-outline .item.breakpoint.selected:focus .status > .status-image.resolved { Note that if we ever support multiple item selection for this treeOutline, than it would need to change from: .tree-outline .item.selected:focus to .tree-outline:focus-within .item.selected This also applies to a bunch of cases below.
Devin Rousso
Comment 3 2020-03-20 17:04:35 PDT
Created attachment 394149 [details] Patch
EWS
Comment 4 2020-03-21 11:06:37 PDT
Committed r258809: <https://trac.webkit.org/changeset/258809> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394149 [details].
Radar WebKit Bug Importer
Comment 5 2020-03-21 11:07:12 PDT
<rdar://problem/60727498>
Note You need to log in before you can comment on or make changes to this bug.