Bug 208506

Summary: REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cgarcia, commit-queue, fujii.hironori, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Diego Pino
Reported 2020-03-03 02:08:54 PST
[GTK] Unreviewed, remove unnecessary code which made LayoutTests crash
Attachments
Patch (1.26 KB, patch)
2020-03-03 02:28 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (1.28 KB, patch)
2020-03-03 04:15 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-03-03 02:28:39 PST
Created attachment 392256 [details] Patch
Diego Pino
Comment 2 2020-03-03 04:15:13 PST
Created attachment 392260 [details] Patch
WebKit Commit Bot
Comment 3 2020-03-03 05:16:41 PST
Comment on attachment 392260 [details] Patch Clearing flags on attachment: 392260 Committed r257772: <https://trac.webkit.org/changeset/257772>
WebKit Commit Bot
Comment 4 2020-03-03 05:16:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-03 05:17:19 PST
<rdar://problem/59992464>
Fujii Hironori
Comment 6 2020-03-24 13:34:51 PDT
Comment on attachment 392260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392260&action=review > Tools/WebKitTestRunner/TestController.cpp:-3102 > - WKWebsiteDataStoreSetResourceLoadStatisticsEnabled(websiteDataStore(), true); WKWebsiteDataStoreSetResourceLoadStatisticsEnabled seems needed for WinCairo port because it enables RESOURCE_LOAD_STATISTICS. I'm going to fix it in Bug 209410.
Note You need to log in before you can comment on or make changes to this bug.