Bug 208503

Summary: Web Inspector: setting the frontend appearance doesn't update the window when undocked
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 186308    
Bug Blocks: 208557    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-03-03 00:07:34 PST
# STEPS TO REPRODUCE: 1. inspect any page 2. detach/undock Web Inspector 3. go to the Settings Tab 4. change the Appearance to the opposite of the system appearance => content changes, but the title of the window doesn't
Attachments
Patch (30.74 KB, patch)
2020-03-03 01:04 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (30.66 KB, patch)
2020-03-03 11:33 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-03-03 01:04:34 PST
Created attachment 392253 [details] Patch
Timothy Hatcher
Comment 2 2020-03-03 09:54:20 PST
Comment on attachment 392253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392253&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:239 > + m_frontendPage->setUseDarkAppearanceOverride(false); You should not need to do this if you force the appearance on the window. > Source/WebCore/inspector/InspectorFrontendHost.cpp:247 > + m_frontendPage->setUseDarkAppearanceOverride(true); Ditto. > Source/WebCore/inspector/InspectorFrontendHost.cpp:254 > m_frontendPage->setUseDarkAppearanceOverride(WTF::nullopt); Ditto.
Devin Rousso
Comment 3 2020-03-03 11:33:27 PST
Created attachment 392303 [details] Patch
WebKit Commit Bot
Comment 4 2020-03-03 14:10:52 PST
The commit-queue encountered the following flaky tests while processing attachment 392303 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-03-03 14:11:35 PST
Comment on attachment 392303 [details] Patch Clearing flags on attachment: 392303 Committed r257801: <https://trac.webkit.org/changeset/257801>
WebKit Commit Bot
Comment 6 2020-03-03 14:11:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-03 14:12:21 PST
<rdar://problem/60012509>
Note You need to log in before you can comment on or make changes to this bug.