Bug 206105

Summary: WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Plug-insAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-01-10 15:39:21 PST
WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert. This makes it easier to determine which installed plugin is causing this test to fail: imported/w3c/web-platform-tests/content-security-policy/plugin-types/plugintypes-nourl-allowed.html
Attachments
Patch v1 (1.75 KB, patch)
2020-01-10 15:43 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2020-01-10 15:42:49 PST
Usually I was able to tell from test source. This one contains "application/x-shockwave-flash".
David Kilzer (:ddkilzer)
Comment 2 2020-01-10 15:43:10 PST
Created attachment 387386 [details] Patch v1
Radar WebKit Bug Importer
Comment 3 2020-01-10 15:43:24 PST
<rdar://problem/58493937>
David Kilzer (:ddkilzer)
Comment 4 2020-01-10 15:45:16 PST
(In reply to Alexey Proskuryakov from comment #1) > Usually I was able to tell from test source. This one contains > "application/x-shockwave-flash". Okay, that's wasn't obvious to me from the comment in the source.
David Kilzer (:ddkilzer)
Comment 5 2020-01-10 16:24:25 PST
(In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to Alexey Proskuryakov from comment #1) > > Usually I was able to tell from test source. This one contains > > "application/x-shockwave-flash". > > Okay, that's wasn't obvious to me from the comment in the source. "source" here refers to the C++ source in Tools/WebKitTestRunner/TestController.cpp.
Brent Fulgham
Comment 6 2020-01-13 11:38:42 PST
Comment on attachment 387386 [details] Patch v1 Oh heck yes! r=me.
David Kilzer (:ddkilzer)
Comment 7 2020-01-13 12:21:03 PST
The ios-wk2 test failure appears to be unrelated.
WebKit Commit Bot
Comment 8 2020-01-13 17:08:25 PST
The commit-queue encountered the following flaky tests while processing attachment 387386 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2020-01-13 17:08:53 PST
Comment on attachment 387386 [details] Patch v1 Clearing flags on attachment: 387386 Committed r254473: <https://trac.webkit.org/changeset/254473>
WebKit Commit Bot
Comment 10 2020-01-13 17:08:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.