Bug 205772

Summary:

Proxy's [[OwnPropertyKeys]] is correct only in PropertyNameMode::StringsAndSymbols

Product:

WebKit

Reporter:

Alexey Shvayka <ashvayka>

Component:

JavaScriptCore

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=203818

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ross.kirsling: review+
Patch	none

Alexey Shvayka

Reported 2020-01-04 17:19:55 PST

ECMA262: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys (step 11) 1. If Object.getOwnPropertyNames is called on Proxy with "ownKeys" trap, symbol keys of Proxy's target are ignored during invariants validation. Test262: https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-absent-not-configurable-symbol-key.js https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-absent-symbol-key.js https://test262.report/browse/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-extra-symbol-key.js 2. If Object.getOwnPropertySymbols is called on Proxy with "ownKeys" trap, string keys of Proxy's target are ignored during invariants validation. Test262: https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-absent-not-configurable-string-key.js https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-absent-string-key.js https://test262.report/browse/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-extra-string-key.js

Attachments
Patch (5.73 KB, patch) 2020-01-04 20:03 PST, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (5.79 KB, patch) 2020-01-06 12:05 PST, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (7.13 KB, patch) 2020-01-07 12:18 PST, Alexey Shvayka	ross.kirsling: review+	Details Formatted Diff Diff
Patch (7.13 KB, patch) 2020-01-08 07:27 PST, Alexey Shvayka	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexey Shvayka

Comment 1 2020-01-04 20:03:12 PST

Created attachment 386780 [details] Patch

Alexey Shvayka

Comment 2 2020-01-06 12:05:10 PST

Created attachment 386874 [details] Patch Rebase patch.

Alexey Shvayka

Comment 3 2020-01-07 12:18:39 PST

Created attachment 387017 [details] Patch Remove `seenKeys` and explanation comment about it.

Ross Kirsling

Comment 4 2020-01-07 16:45:40 PST

Comment on attachment 387017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387017&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + (step 11 of https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys) Seems like it's more than just step 11 though, right?

Alexey Shvayka

Comment 5 2020-01-08 07:27:06 PST

Created attachment 387104 [details] Patch Set reviewer and tweak ChangeLog.

WebKit Commit Bot

Comment 6 2020-01-08 10:58:47 PST

Comment on attachment 387104 [details] Patch Clearing flags on attachment: 387104 Committed r254205: <https://trac.webkit.org/changeset/254205>

WebKit Commit Bot

Comment 7 2020-01-08 10:58:48 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2020-01-08 10:59:20 PST

<rdar://problem/58414163>

Note You need to log in before you can comment on or make changes to this bug.