Bug 203134

Summary: Integrate media query evaluation into HTML5 event loop
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, cdumez, cfleizach, commit-queue, dbates, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, hi, jer.noble, joepeck, kangil.han, koivisto, macpherson, menard, philipj, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203855
Bug Depends on: 203430    
Bug Blocks: 202843    
Attachments:
Description Flags
WIP
none
Patch
none
Updated for trunk koivisto: review+

Ryosuke Niwa
Reported 2019-10-17 21:16:46 PDT
Media queries' listeners should be called during the step to update the rendering, not after each layout update.
Attachments
WIP (2.66 KB, patch)
2019-10-17 21:18 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (14.82 KB, patch)
2019-10-17 23:24 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for trunk (17.34 KB, patch)
2019-10-31 15:10 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-10-17 21:18:43 PDT
Created attachment 381267 [details] WIP
Radar WebKit Bug Importer
Comment 2 2019-10-17 21:18:59 PDT
<rdar://problem/56396316>
Ryosuke Niwa
Comment 3 2019-10-17 23:24:31 PDT
Created attachment 381278 [details] Patch
chris fleizach
Comment 4 2019-10-19 00:06:44 PDT
lgtm
Ryosuke Niwa
Comment 5 2019-10-19 00:35:00 PDT
Comment on attachment 381278 [details] Patch Thanks all for reviewing!
WebKit Commit Bot
Comment 6 2019-10-19 01:31:07 PDT
Comment on attachment 381278 [details] Patch Clearing flags on attachment: 381278 Committed r251322: <https://trac.webkit.org/changeset/251322>
WebKit Commit Bot
Comment 7 2019-10-19 01:31:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2019-10-25 12:25:32 PDT
Re-opened since this is blocked by bug 203430
Ryosuke Niwa
Comment 9 2019-10-31 15:10:16 PDT
Created attachment 382507 [details] Updated for trunk
Ryosuke Niwa
Comment 10 2019-10-31 19:19:05 PDT
Ping reviewers. There is a minor test code change & fix since the rollout revealed a bug with respect to accessibility settings update.
Antti Koivisto
Comment 11 2019-11-01 08:17:11 PDT
Comment on attachment 382507 [details] Updated for trunk View in context: https://bugs.webkit.org/attachment.cgi?id=382507&action=review > Source/WebCore/page/Page.cpp:568 > + forEachDocument([] (Document& document) { We probably don't have a policy about this but no space between ] and ( wins 2:1 when searching WebCore.
Ryosuke Niwa
Comment 12 2019-11-01 11:11:47 PDT
(In reply to Antti Koivisto from comment #11) > Comment on attachment 382507 [details] > Updated for trunk > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382507&action=review > > > Source/WebCore/page/Page.cpp:568 > > + forEachDocument([] (Document& document) { > > We probably don't have a policy about this but no space between ] and ( wins > 2:1 when searching WebCore. Huh, I always add a space there. We should probably discuss it on webkit-dev.
Ryosuke Niwa
Comment 13 2019-11-01 11:16:15 PDT
Committed r251930: <https://trac.webkit.org/changeset/251930>
Note You need to log in before you can comment on or make changes to this bug.