Bug 202479

Summary: Make DOMPoint a DOMLiveObject
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED INVALID    
Severity: Normal CC: annulen, cdumez, dbates, dino, esprehn+autocc, ews-watchlist, fmalita, gyuyoung.kim, kangil.han, kondapallykalyan, pdr, rakuco, ryuan.choi, schenney, sergio, ysuzuki, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201782    
Bug Blocks: 191376    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for review ysuzuki: review-

Said Abou-Hallawa
Reported 2019-10-02 10:43:33 PDT
In order to replace SVGPoint by DOMPoint, DOMPoint has to communicate changes with its observer. Changing DOMPoint will not be allowed if the observer is read-only.
Attachments
Patch (98.50 KB, patch)
2019-10-02 10:57 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (102.21 KB, patch)
2019-10-03 10:02 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (102.88 KB, patch)
2019-10-03 10:38 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (102.90 KB, patch)
2019-10-03 10:49 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (102.90 KB, patch)
2019-10-03 11:52 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (32.16 KB, patch)
2019-10-03 12:55 PDT, Said Abou-Hallawa 		ysuzuki: review-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-10-02 10:57:53 PDT
Created attachment 380037 [details] Patch
Said Abou-Hallawa
Comment 2 2019-10-03 10:02:37 PDT
Created attachment 380127 [details] Patch
Said Abou-Hallawa
Comment 3 2019-10-03 10:38:12 PDT
Created attachment 380130 [details] Patch
Said Abou-Hallawa
Comment 4 2019-10-03 10:49:18 PDT
Created attachment 380133 [details] Patch
Said Abou-Hallawa
Comment 5 2019-10-03 11:52:31 PDT
Created attachment 380147 [details] Patch
Yusuke Suzuki
Comment 6 2019-10-03 12:03:50 PDT
Comment on attachment 380147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380147&action=review > Source/WebCore/dom/DOMPoint.h:98 > +static_assert(sizeof(DOMPoint) == sizeof(DOMPointReadOnly) + sizeof(DOMLiveProperty), ""); Let's remove this. This `static_assert` ensures that it is OK that DOMPoint shares the same IsoHeap with DOMPointReadOnly. But now, this patch changes DOMPoint, and now they are not the same layout. This patch introduced IsoHeap for DOMPoint (this is mandatory), and then, this static_assert is not necessary.
Said Abou-Hallawa
Comment 7 2019-10-03 12:55:14 PDT
Created attachment 380154 [details] Patch for review
Said Abou-Hallawa
Comment 8 2019-10-07 17:23:58 PDT
*** Bug 201783 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 9 2020-06-15 10:50:42 PDT
Comment on attachment 380154 [details] Patch for review r- because applying the patch does not work. Looks like rebase is necessary.
Said Abou-Hallawa
Comment 10 2020-06-15 11:47:02 PDT
Replacing SVGRect/SVGPoint/SVGMatrix by DOM equivalents was reverted in the specs: https://github.com/w3c/svgwg/issues/706. So this bug is now invalid and the attached patch should not be considered.
Note You need to log in before you can comment on or make changes to this bug.