Bug 20095

Summary: [Qt] Windowless plugin does not work on Qt port for Windows
Product: WebKit Reporter: Chris Kurecka <ckurecka>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Major CC: girish, jturcotte, tonikitoo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 35962    
Attachments:
Description Flags
Zattoo's modified PluginViewWin.cpp file
none
Zattoo's modified PluginView.h file none

Chris Kurecka
Reported 2008-07-18 09:16:58 PDT
It seems the changes for windowed mode to work in QtWebKit/Win broke nonwindowed mode in svn trunk.
Attachments
Zattoo's modified PluginViewWin.cpp file (26.17 KB, text/x-c++src)
2008-07-18 12:06 PDT, Chris Kurecka 		no flags
Details
Zattoo's modified PluginView.h file (9.25 KB, text/x-chdr)
2008-07-18 12:07 PDT, Chris Kurecka 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Chris Kurecka
Comment 1 2008-07-18 12:04:48 PDT
We've been working independently on getting both working, and though I'm sure some of this might not be ideal for a final product, I'm attaching the code we wrote to make both modes work. The gist of it is that it uses WHND instead of PlatformWidget in most places, and some other changes happened accordingly.
Chris Kurecka
Comment 2 2008-07-18 12:06:49 PDT
Created attachment 22369 [details] Zattoo's modified PluginViewWin.cpp file
Chris Kurecka
Comment 3 2008-07-18 12:07:08 PDT
Created attachment 22370 [details] Zattoo's modified PluginView.h file
Antonio Gomes
Comment 4 2009-10-21 20:38:43 PDT
girish no one better than girish to move forward on this i believe.
Girish Ramakrishnan
Comment 5 2009-10-21 20:41:56 PDT
(In reply to comment #0) > It seems the changes for windowed mode to work in QtWebKit/Win broke > nonwindowed mode in svn trunk. What are these changes? Is this a 4.6 blocker? I will prioritize accordingly.
Girish Ramakrishnan
Comment 6 2009-11-06 03:43:10 PST
I won't be able to work on this.
Girish Ramakrishnan
Comment 7 2010-08-19 22:26:55 PDT
This should be fixed by now. Can we close this?
Jocelyn Turcotte
Comment 8 2014-02-03 03:12:53 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.