Bug 199698

Summary: Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, ggaren, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195935
https://bugs.webkit.org/show_bug.cgi?id=199775
Bug Depends on:    
Bug Blocks: 199639    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-07-10 19:34:12 PDT
Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit.
Attachments
Patch (3.03 KB, patch)
2019-07-10 19:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.20 KB, patch)
2019-07-11 12:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-07-10 19:38:01 PDT
Created attachment 373898 [details] Patch
Brent Fulgham
Comment 2 2019-07-10 22:10:26 PDT
Comment on attachment 373898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373898&action=review I’m not comfortable with this change unless we add some release asserts to prevent this member from being in an invalid state. I can talk to you in person next week if you want background on why this is important. > Source/WebCore/ChangeLog:14 > + purposes (Not trying to address a particular crash). I think your patch should include release-asserts that the pointer is in a safe state when assigned, when being destroyed, etc.
Chris Dumez
Comment 3 2019-07-11 12:44:12 PDT
Created attachment 373939 [details] Patch
WebKit Commit Bot
Comment 4 2019-07-11 19:35:14 PDT
Comment on attachment 373939 [details] Patch Clearing flags on attachment: 373939 Committed r247380: <https://trac.webkit.org/changeset/247380>
WebKit Commit Bot
Comment 5 2019-07-11 19:35:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-11 19:36:43 PDT
<rdar://problem/52985961>
Note You need to log in before you can comment on or make changes to this bug.