Bug 199428

Summary: [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: Tools / TestsAssignee: Fujii Hironori <fujii>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dean_johnson, don.olmstead, ews-watchlist, glenn, jbedard, ross.kirsling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199078
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2019-07-02 19:15:44 PDT
[Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith' AppleWin and WinCairo are failing. https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/2856 https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4417 > Traceback (most recent call last): > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 374, in <module> > sys.exit(main()) > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 72, in main > if not _supports_building_and_running_lldb_tests(): > File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 107, in _supports_building_and_running_lldb_tests > return not _host.platform.build_version().startswith('19A') > AttributeError: 'NoneType' object has no attribute 'startswith' Since Bug 199078.
Attachments
Patch (1.41 KB, patch)
2019-07-02 19:25 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-07-02 19:25:59 PDT
Created attachment 373377 [details] Patch
Jonathan Bedard
Comment 2 2019-07-03 07:17:00 PDT
Comment on attachment 373377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review > Tools/Scripts/webkitpy/test/main.py:106 > + return False Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right?
Fujii Hironori
Comment 3 2019-07-03 18:51:27 PDT
Comment on attachment 373377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review >> Tools/Scripts/webkitpy/test/main.py:106 >> + return False > > Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right? Yup. build_version is available only for mac. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py?rev=243030#L150
Fujii Hironori
Comment 4 2019-07-04 07:01:38 PDT
*** This bug has been marked as a duplicate of bug 199493 ***
Note You need to log in before you can comment on or make changes to this bug.