Bug 199353

Summary: [iOS] Do not disable scrolling when WKScrollView subviews intersect the content inset areas
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: NEW    
Severity: Normal CC: achristensen, jonlee, koivisto, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2019-07-01 02:08:33 PDT
[iOS] Do not disable scrolling when content has been added to WKScrollView's margins
Attachments
Patch (12.09 KB, patch)
2019-07-01 02:09 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (12.42 KB, patch)
2019-07-01 17:40 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-07-01 02:09:35 PDT
Created attachment 373216 [details] Patch
Andy Estes
Comment 2 2019-07-01 02:09:37 PDT
<rdar://problem/50822146>
Tim Horton
Comment 3 2019-07-01 02:43:51 PDT
Margins!
Andy Estes
Comment 4 2019-07-01 17:40:58 PDT
Created attachment 373290 [details] Patch
Jon Lee
Comment 5 2019-07-08 16:45:52 PDT
(In reply to Andy Estes from comment #4) > Created attachment 373290 [details] > Patch Should this be "r?"?
Simon Fraser (smfr)
Comment 6 2019-07-09 14:56:31 PDT
Comment on attachment 373290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373290&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2029 > + [_scrollView _setScrollEnabledInternal:_page->scrollingCoordinatorProxy()->hasScrollableMainFrame() || hasDockedInputView || isZoomed || [_scrollView _hasContentInRelevantInsetAreas]]; I'm working on a change that will make this scrollable if the visualViewport is smaller than the layoutViewport. Does that help in this case?
Andy Estes
Comment 7 2019-07-10 14:07:06 PDT
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 373290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373290&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2029 > > + [_scrollView _setScrollEnabledInternal:_page->scrollingCoordinatorProxy()->hasScrollableMainFrame() || hasDockedInputView || isZoomed || [_scrollView _hasContentInRelevantInsetAreas]]; > > I'm working on a change that will make this scrollable if the visualViewport > is smaller than the layoutViewport. Does that help in this case? It might happen to fix rdar://problem/50822146 by accident, but in general I don't think so. This is about scrolling to items positioned outside of our content view.
Note You need to log in before you can comment on or make changes to this bug.