Bug 199314

Summary:

Re-enable some prefetch tests

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

Tools / Tests

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ews-watchlist, fred.wang, rniwa, yoav, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Archive of layout-test-results from ews210 for win-future	none
Patch	none
Patch	none

Rob Buis

Reported 2019-06-28 00:33:12 PDT

Re-enable some prefetch tests thhat aare passing.

Attachments
Patch (4.09 KB, patch) 2019-06-28 00:44 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.25 MB, application/zip) 2019-06-28 01:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (3.04 MB, application/zip) 2019-06-28 02:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews210 for win-future (13.69 MB, application/zip) 2019-06-28 02:45 PDT, EWS Watchlist	no flags	Details
Patch (6.44 KB, patch) 2019-06-28 05:04 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (10.07 KB, patch) 2019-06-28 07:17 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-06-28 00:44:12 PDT

Created attachment 373094 [details] Patch

EWS Watchlist

Comment 2 2019-06-28 01:59:31 PDT

Comment on attachment 373094 [details] Patch Attachment 373094 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12600988 New failing tests: fast/dom/HTMLLinkElement/subresource.html fast/dom/HTMLLinkElement/prefetch-onload.html fast/dom/HTMLLinkElement/link-and-subresource-test.html fast/dom/HTMLLinkElement/prefetch.html http/tests/misc/prefetch-purpose.html fast/dom/HTMLLinkElement/prefetch-onerror.html fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

EWS Watchlist

Comment 3 2019-06-28 01:59:33 PDT

Created attachment 373097 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-06-28 02:38:53 PDT

Comment on attachment 373094 [details] Patch Attachment 373094 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12601020 New failing tests: fast/dom/HTMLLinkElement/subresource.html fast/dom/HTMLLinkElement/prefetch-onload.html fast/dom/HTMLLinkElement/link-and-subresource-test.html fast/dom/HTMLLinkElement/prefetch.html http/tests/misc/prefetch-purpose.html fast/dom/HTMLLinkElement/prefetch-onerror.html fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

EWS Watchlist

Comment 5 2019-06-28 02:38:54 PDT

Created attachment 373099 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-06-28 02:45:18 PDT

Comment on attachment 373094 [details] Patch Attachment 373094 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12601102 New failing tests: fast/dom/HTMLLinkElement/subresource.html fast/dom/HTMLLinkElement/prefetch-onload.html fast/dom/HTMLLinkElement/prefetch-onerror.html fast/dom/HTMLLinkElement/prefetch.html http/tests/misc/prefetch-purpose.html fast/dom/HTMLLinkElement/link-and-subresource-test.html fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

EWS Watchlist

Comment 7 2019-06-28 02:45:21 PDT

Created attachment 373100 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Rob Buis

Comment 8 2019-06-28 05:04:13 PDT

Created attachment 373105 [details] Patch

Frédéric Wang (:fredw)

Comment 9 2019-06-28 06:32:27 PDT

Comment on attachment 373105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373105&action=review > LayoutTests/ChangeLog:10 > + * platform/win/TestExpectations: Can you add a comment about the new expectations? > LayoutTests/platform/mac/TestExpectations:1946 > + I think new bugs should be opened for mac and win.

Rob Buis

Comment 10 2019-06-28 07:17:19 PDT

Created attachment 373114 [details] Patch

Rob Buis

Comment 11 2019-06-28 07:18:49 PDT

Yoav, could you have a look as well? I am wondering if some of these can be removed by equivalent WPT tests?

Rob Buis

Comment 12 2019-07-09 04:10:29 PDT

This patch is probably doing too much at once, will split it up.

Note You need to log in before you can comment on or make changes to this bug.