Bug 199301

Summary: Provide overrides for UIKit's suggested actions in UIContextMenuInteraction
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Dean Jackson
Reported 2019-06-27 17:42:03 PDT
Provide overrides for UIKit's suggested actions in UIContextMenuInteraction
Attachments
Patch (11.64 KB, patch)
2019-06-27 17:47 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-27 17:43:42 PDT
<rdar://problem/52297380>
Dean Jackson
Comment 2 2019-06-27 17:47:36 PDT
Created attachment 373073 [details] Patch
Tim Horton
Comment 3 2019-06-27 17:50:15 PDT
Comment on attachment 373073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373073&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:1191 > -@interface UIContextMenuConfiguration (NeededUntil51288435Fixed) > +@interface UIContextMenuConfiguration (NeededUntil52295535Fixed) oO that's quite the coincidence > Source/WebKit/Platform/spi/ios/UIKitSPI.h:1202 > +// FIXME: I don't think this Radar is correct. 51288435 is about something else. Seems like a silly comment :) Just fix it?
Dean Jackson
Comment 4 2019-06-27 18:05:24 PDT
Comment on attachment 373073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373073&action=review >> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1191 >> +@interface UIContextMenuConfiguration (NeededUntil52295535Fixed) > > oO that's quite the coincidence Haha. They fixed the original radar, which helped a bit, but not completely, so I filed a new one. >> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1202 >> +// FIXME: I don't think this Radar is correct. 51288435 is about something else. > > Seems like a silly comment :) Just fix it? It seems like there was never a radar filed for this. I just created one.
Dean Jackson
Comment 5 2019-06-27 18:06:51 PDT
Committed r246912: <https://trac.webkit.org/changeset/246912>
Note You need to log in before you can comment on or make changes to this bug.