Bug 199294

Summary: Add new -[WKWebView _closeAllMediaPresentations] SPI
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, ryanhaddad, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2019-06-27 15:44:11 PDT
Add new -[WKWebView _closeAllMediaPresentations] SPI
Attachments
Patch (19.57 KB, patch)
2019-06-27 15:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-06-27 15:44:53 PDT
<rdar://problem/51965958>
Jer Noble
Comment 2 2019-06-27 15:49:31 PDT
Created attachment 373061 [details] Patch
Eric Carlson
Comment 3 2019-06-28 10:28:26 PDT
Comment on attachment 373061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373061&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4747 > + if (auto fullScreenManager = _page->fullScreenManager(); fullScreenManager && fullScreenManager->isFullScreen()) Are both "fullScreenManager" tests necessary?
WebKit Commit Bot
Comment 4 2019-06-28 10:39:59 PDT
Comment on attachment 373061 [details] Patch Clearing flags on attachment: 373061 Committed r246928: <https://trac.webkit.org/changeset/246928>
WebKit Commit Bot
Comment 5 2019-06-28 10:40:00 PDT
All reviewed patches have been landed. Closing bug.
Jer Noble
Comment 7 2019-07-01 07:13:20 PDT
I don’t think that last revision was a good fix. Now this SPI won’t work on platforms that support video-full screen but don’t support element-fullscreen.
Note You need to log in before you can comment on or make changes to this bug.