Bug 199266

Summary: JSC binary not being copied into payload for benchmarking
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: Tools / TestsAssignee: Paulo Matos <pmatos>
Status: NEW    
Severity: Normal CC: dewei_zhu, ews-watchlist, fpizlo, jbedard, krollin, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
pmatos: review?, ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-highsierra-wk2 none

Paulo Matos
Reported 2019-06-27 04:51:42 PDT
JSC binary not being copied into payload for benchmarking
Attachments
Patch (1.22 KB, patch)
2019-06-27 04:53 PDT, Paulo Matos 		pmatos: review?
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.72 MB, application/zip)
2019-06-27 06:09 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2019-06-27 04:53:05 PDT
Created attachment 373018 [details] Patch
EWS Watchlist
Comment 2 2019-06-27 06:09:05 PDT
Comment on attachment 373018 [details] Patch Attachment 373018 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12591504 New failing tests: webgpu/whlsl-two-dimensional-array.html
EWS Watchlist
Comment 3 2019-06-27 06:09:07 PDT
Created attachment 373024 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Paulo Matos
Comment 4 2019-07-09 00:14:12 PDT
ping! Would anyone care to take a look at this please?
Jonathan Bedard
Comment 5 2019-07-09 15:02:35 PDT
I need someone else to verify this is what we want. It seems like if we had wanted this, we would have included the JSC binary in the libPath array, no? I added Filip Pizlo as a reviewer, he's the one who added most of the code in this area.
Saam Barati
Comment 6 2019-07-09 15:13:36 PDT
Comment on attachment 373018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373018&action=review > Tools/ChangeLog:9 > + * Scripts/run-jsc-benchmarks: Copy jsc into benchmark temp > + so that's it is properly added into payload. What we going wrong in the current set up?
Paulo Matos
Comment 7 2019-10-17 05:23:26 PDT
Sorry - I dropped the ball on this one. Let me get this one sorted next.
Note You need to log in before you can comment on or make changes to this bug.