Bug 199045

Summary: No menu pop-up when long pressing on a link in Firefox app
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch none

Dean Jackson
Reported 2019-06-19 17:55:07 PDT
No menu pop-up when long pressing on a link in Firefox app
Attachments
Patch (9.88 KB, patch)
2019-06-19 17:58 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2019-06-19 18:02 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (10.74 KB, patch)
2019-06-19 18:45 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2019-06-19 17:55:42 PDT
<rdar://problem/51422407>
Dean Jackson
Comment 2 2019-06-19 17:58:40 PDT
Created attachment 372505 [details] Patch
Tim Horton
Comment 3 2019-06-19 17:59:55 PDT
Comment on attachment 372505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372505&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7450 > + _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer; IMO [ ] instead of .get() but could go either way
Dean Jackson
Comment 4 2019-06-19 18:02:12 PDT
Created attachment 372506 [details] Patch
Dean Jackson
Comment 5 2019-06-19 18:45:45 PDT
Created attachment 372511 [details] Patch
Dean Jackson
Comment 6 2019-06-19 19:18:06 PDT
Committed r246626: <https://trac.webkit.org/changeset/246626>
Note You need to log in before you can comment on or make changes to this bug.