Bug 198974

Created attachment 372371 [details] Patch

<rdar://problem/50735687>

Comment on attachment 372371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372371&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h:170 > +- (void)webView:(WKWebView *)webView contextMenuConfigurationForElement:(WKContextMenuElementInfo *)elementInfo completionHandler:(void (^)(UIContextMenuConfiguration * _Nullable))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA)); I think you want to name the block parameters so that Xcode pops a name in for you? We do in other places. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:489 > +- (void)ensurePositionInformationIsUpToDate:(const WebKit::InteractionInformationRequest&)request completionHandler:(CompletionHandler<void(BOOL)>&&)completionHandler; I don't think we need an additional way to get async position information updates; see above.

Created attachment 372391 [details] Patch

Comment on attachment 372391 [details] Patch Rejecting attachment 372391 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 372391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=372391&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=198974&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 372391 from bug 198974. Fetching: https://bugs.webkit.org/attachment.cgi?id=372391 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h Hunk #1 succeeded at 45 with fuzz 2 (offset 6 lines). Hunk #2 FAILED at 141. Hunk #3 FAILED at 156. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h.rej patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h Hunk #1 FAILED at 147. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h Hunk #1 succeeded at 45 with fuzz 2 (offset 6 lines). Hunk #2 FAILED at 141. Hunk #3 FAILED at 156. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h.rej patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h Hunk #1 FAILED at 147. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 4a8cbd8f81f..50e451c1e4c master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 246572 = 4a8cbd8f81fbb759640f01fd804aa90361784fc6 r246573 = a49db596d6b7c9466c743d99f3879840310f23f4 r246574 = 4a74c0a384396b431f750f144c52f50ae70d3656 r246575 = 4b20a15db3add74bf10b1bd28986f3ce0afbcff2 r246576 = 50e451c1e4c55505257a6ac5faa3a629e99b8f89 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/12513573

Reverted r246575 for reason: Breaks internal builds. Committed r246580: <https://trac.webkit.org/changeset/246580>

This was relanded in these two patches: https://trac.webkit.org/changeset/246583/webkit http://trac.webkit.org/r246598