Bug 198972

Summary: webkit-patch should allow for a bugzilla url not just bugzilla id
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dewei_zhu, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Keith Miller
Reported 2019-06-18 12:05:07 PDT
webkit-patch should allow for a bugzilla url not just bugzilla id
Attachments
Patch (2.80 KB, patch)
2019-06-18 12:06 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.76 KB, patch)
2019-06-18 13:29 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-06-18 12:06:43 PDT
Created attachment 372359 [details] Patch
dewei_zhu
Comment 2 2019-06-18 13:24:23 PDT
Comment on attachment 372359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:61 > + 1 use 'pass'
dewei_zhu
Comment 3 2019-06-18 13:25:36 PDT
Comment on attachment 372359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51 > + parsed_url = None You doin't need to initialize a parsed_url here.
Keith Miller
Comment 4 2019-06-18 13:29:05 PDT
Created attachment 372373 [details] Patch for landing
Keith Miller
Comment 5 2019-06-18 13:30:05 PDT
(In reply to dewei_zhu from comment #3) > Comment on attachment 372359 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372359&action=review > > > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51 > > + parsed_url = None > > You doin't need to initialize a parsed_url here. As discussed offline. I meant to move the code out of the try catch block, which I have done for the final patch.
WebKit Commit Bot
Comment 6 2019-06-18 14:11:37 PDT
Comment on attachment 372373 [details] Patch for landing Clearing flags on attachment: 372373 Committed r246566: <https://trac.webkit.org/changeset/246566>
WebKit Commit Bot
Comment 7 2019-06-18 14:11:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-18 14:12:28 PDT
<rdar://problem/51865072>
Note You need to log in before you can comment on or make changes to this bug.