Bug 198941

Summary: Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-06-17 16:51:23 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines tab 3. enable "JavaScript Allocations" 4. take a heap snapshot => the [S] appears in the graph area and in the "Snapshot List" area 5. take another heap snapshot => the [S] appears in the graph area, but _not_ in the "Snapshot List" area
Attachments
Patch (2.62 KB, patch)
2019-06-17 21:47 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.71 KB, patch)
2019-06-17 21:49 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-17 21:26:45 PDT
Interestingly, it looks like it's only an issue when the entire recording is selected (e.g. double clicking the overview graph area).
Devin Rousso
Comment 2 2019-06-17 21:47:54 PDT
Created attachment 372323 [details] Patch
Devin Rousso
Comment 3 2019-06-17 21:49:03 PDT
Created attachment 372324 [details] Patch webkit-patch didn't catch my last changes :(
Joseph Pecoraro
Comment 4 2019-06-18 11:44:00 PDT
Comment on attachment 372324 [details] Patch Nice, r=me
WebKit Commit Bot
Comment 5 2019-06-18 12:33:48 PDT
Comment on attachment 372324 [details] Patch Clearing flags on attachment: 372324 Committed r246558: <https://trac.webkit.org/changeset/246558>
WebKit Commit Bot
Comment 6 2019-06-18 12:33:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-06-18 12:34:28 PDT
<rdar://problem/51860940>
Note You need to log in before you can comment on or make changes to this bug.